Regression testing: fix compilation for unusual configs #7699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable ECC but have OPENSSL_EXTRA and curve25519 - fix #ifdef protection in ssl.c. tests/api.c: SSL_SESSION_get_max_fragment_length is not available when no session cache. ASN1 APIs using generalized time disabled when NO_ASN_TIME defined so disable tests.
JacobBarthelmeh
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable ECC but have OPENSSL_EXTRA and curve25519 - fix #ifdef protection in ssl.c.
tests/api.c:
SSL_SESSION_get_max_fragment_length is not available when no session cache.
ASN1 APIs using generalized time disabled when NO_ASN_TIME defined so disable tests.
Testing
./configure --disable-shared 'CC=clang -fsanitize=address,undefined -g' --enable-all CFLAGS=-DNO_ASN_TIME
./configure --disable-shared 'CC=clang -fsanitize=address,undefined -g' --enable-opensslall --enable-rsa --enable-curve25519 --disable-dh --disable-ecc
Checklist