Dilithium: support fixed size arays in dilithium_key #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
dilithium_fixed_array
branch
from
585a1b1
to
1deb1bd
Compare
JacobBarthelmeh
previously approved these changes
Jul 16, 2024
There was a problem hiding this comment.
@SparkiDev please follow up on this with adding the new configuration options for Dilithium into CI testing.
SparkiDev
dismissed
JacobBarthelmeh’s stale review
The merge-base changed after approval.
JacobBarthelmeh
previously approved these changes
Jul 16, 2024
SparkiDev
dismissed
JacobBarthelmeh’s stale review
The merge-base changed after approval.
Support fixed size arrays for pre-generated matrix and vectors. Define: WC_DILITHIUM_FIXED_ARRAY
SparkiDev
force-pushed
the
dilithium_fixed_array
branch
from
1deb1bd
to
500951f
Compare
JacobBarthelmeh
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support fixed size arrays for pre-generated matrix and vectors.
Define: WC_DILITHIUM_FIXED_ARRAY
Testing
./configure '--disable-shared' '--enable-experimental' '--enable-dilithium' 'CFLAGS=-DWC_DILITHIUM_CACHE_PRIV_VECTORS -DWC_DILITHIUM_CACHE_PUB_VECTORS -DWOLFSSL_DILITHIUM_ALIGNMENT=0 -DWC_DILITHIUM_FIXED_ARRAY'
Checklist