Coverity fixes #7733
Merged
Coverity fixes #7733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
coverity_3
branch
3 times, most recently
from
9ef0168
to
ac05caa
Compare
pk.c: EncryptDerKey - setting wrong ret value on allocation failure. wolfssl_rsa_generate_key_native - now checks e is a valid long before passing in. Fix formatting. ssl_load.c: ProcessBufferPrivPkcs8Dec - now checking password is not NULL before zeroizing. Allocation may fail and ForceZero doesn't check for NULL. Fix formatting. tests/api.c: test_RsaSigFailure_cm - Check cert_sz is greater than zero before use. send_new_session_ticket - assert that building the message doesn't return error or 0. test_ticket_nonce_malloc - fix setting of medium and big to use preprocessor. Fix big to be medium + 20. asn.c: GetLength_ex - Fix type of bytes so that it can go negative. sp_int.h: sp_clamp - add one to ii while it is a signed. Fix formatting.
JacobBarthelmeh
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pk.c:
EncryptDerKey - setting wrong ret value on allocation failure.
wolfssl_rsa_generate_key_native - now checks e is a valid long before passing in.
Fix formatting.
ssl_load.c:
ProcessBufferPrivPkcs8Dec - now checking password is not NULL before zeroizing. Allocation may fail and ForceZero doesn't check for NULL.
Fix formatting.
tests/api.c:
test_RsaSigFailure_cm - Check cert_sz is greater than zero before use.
send_new_session_ticket - assert that building the message doesn't return error or 0.
test_ticket_nonce_malloc - fix setting of medium and big to use preprocessor. Fix big to be medium + 20.
asn.c:
GetLength_ex - Fix type of bytes so that it can go negative.
sp_int.h:
sp_clamp - add one to ii while it is a signed.
Fix formatting.
Testing
Standard testing.
Checklist