20240717-fixes #7757
Merged
20240717-fixes #7757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ecc.c: in wc_ecc_free(), fix gating around handling for key->sign_k to resolve memory leak, and in wc_ecc_gen_deterministic_k(), fix -Wconversion. * test.c: add missing mp_free()s to ecdsa_test_deterministic_k_rs() and ecc521_test_deterministic_k(). * wc_HashType: change several occurrences of int to enum wc_HashType, including ecc_key.hashType and API wc_ecc_set_deterministic_ex(), to resolve C++ warnings. * fixes for various C++ warnings/errors in crypto and TLS layers and test and benchmark code -- implicit casts, negative initializers for unsigned type, jumped initializers, and missing enums in switch()es.
SparkiDev
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for defects identified by nightly testing:
ecc.c: inwc_ecc_free(), fix gating around handling forkey->sign_kto resolve memory leak, and inwc_ecc_gen_deterministic_k(), fix-Wconversion.test.c: add missingmp_free()s toecdsa_test_deterministic_k_rs()andecc521_test_deterministic_k().wc_HashType: change several occurrences ofinttoenum wc_HashType, includingecc_key.hashTypeand APIwc_ecc_set_deterministic_ex(), to resolve C++ warnings.fixes for various C++ warnings/errors in crypto and TLS layers and test and benchmark code -- implicit casts, negative initializers for unsigned type, jumped initializers, and missing enums in switch()es.
detected and tested with
wolfssl-multi-test.sh ... quantum-safe-wolfssl-all-intelasm-sp-asm-sanitizer 'quantum-safe-wolfssl-all-g\+\+-latest' allcryptonly-Wconversion-intelasm-build allcryptonly-c99-Wconversion-build allcryptonly-c99-Wconversion-m32-build allcryptonly-c89-Wconversion-build allcryptonly-c89-Wconversion-m32-build 'all-g\+\+-gnu17' lms-xmss-wolfssl-all-clang-sanitizer intmath-sanitizeralso tested with
wolfssl-multi-test.sh ... super-quick-check