Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run the google test if the WOLFSSL_EXTERNAL_TEST env var is set. #7822

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

anhu
Copy link
Member

@anhu anhu commented Aug 1, 2024

Fixes ZD18374

Testing

Run:
WOLFSSL_EXTERNAL_TEST=1 make check

Then run:
make check

Compare the difference.

@anhu anhu requested a review from wolfSSL-Bot August 1, 2024 20:48
@anhu anhu self-assigned this Aug 1, 2024
@@ -6,6 +6,11 @@ server=www.google.com

[ ! -x ./examples/client/client ] && echo -e "\n\nClient doesn't exist" && exit 1

if test -n "$WOLFSSL_NO_GOOGLE_TEST"; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we can't change this to use the existing WOLFSSL_EXTERNAL_TEST env variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason at all. Will make the change.

@anhu anhu changed the title If the WOLFSSL_NO_GOOGLE_TEST env var is set, don't run the google test. Only run the google test if the WOLFSSL_EXTERNAL_TEST env var is set. Aug 1, 2024
@anhu anhu requested a review from dgarske August 1, 2024 21:14
@SparkiDev SparkiDev merged commit 01afe89 into wolfSSL:master Aug 1, 2024
125 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants