Update to the maxq10xx support #7824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
dgarske
requested changes
Aug 2, 2024
wolfcrypt/src/random.c
Outdated
| @@ -3913,6 +3913,17 @@ int wc_GenerateSeed(OS_Seed* os, byte* output, word32 sz) | |||
|
|
|||
| #define USE_TEST_GENSEED | |||
|
|
|||
| #elif defined(WOLFSSL_MAXQ108X) || defined(WOLFSSL_MAXQ1065) | |||
There was a problem hiding this comment.
I see this code already in random.c above at line 3829... I think you can remove this
julek-wolfssl
force-pushed
the
maxq10xx_update
branch
from
4da052e
to
52922ee
Compare
|
Force pushed to run CI |
dgarske
force-pushed
the
maxq10xx_update
branch
from
52922ee
to
29a5cc3
Compare
|
@anhu I rebased this for you... |
dgarske
approved these changes
Aug 6, 2024
|
All tests pass, reviewed and approved. Please merge at earliest convenience . |
douzzer
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.