libspdm x509 parts #7869
Merged
libspdm x509 parts #7869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julek-wolfssl
commented
Aug 14, 2024
•
julek-wolfssl
commented
- RsaFunctionPrivate: detect when only n,e,d are available
- wolfSSL_EVP_add_digest: return success
- wolfSSL_EVP_add_cipher: return success
- wolfSSL_BN_bin2bn: accept NULL data if len is 0 (checked in mp_read_unsigned_bin)
- wolfssl_read_bio: advance correct bio
- wolfSSL_X509_set_ext: return raw extension data for BASIC_CA_OID
- Implement
- sk_X509_EXTENSION_free
- d2i_EC_PUBKEY_bio
- d2i_RSA_PUBKEY_bio
- d2i_X509_REQ_INFO
- X509_REQ_INFO_free
- ASN1_TIME_set_string_X509
julek-wolfssl
force-pushed
the
libspdm-x509
branch
7 times, most recently
from
8a1c07a to
30522ab
Compare
|
Failures (not sure about |
julek-wolfssl
force-pushed
the
libspdm-x509
branch
from
30522ab to
f6f4c55
Compare
|
retest this please. . |
julek-wolfssl
force-pushed
the
libspdm-x509
branch
2 times, most recently
from
84113a0 to
fdb7221
Compare
julek-wolfssl
force-pushed
the
libspdm-x509
branch
2 times, most recently
from
5f172cb to
07e9a60
Compare
douzzer
requested changes
Sep 2, 2024
| @@ -25546,7 +25546,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t openssl_test(void) | |||
| return WC_TEST_RET_ENC_NC; | |||
| } | |||
|
|
|||
| if (EVP_CIPHER_CTX_block_size(NULL) != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) | |||
| if (EVP_CIPHER_CTX_block_size(NULL) != WOLFSSL_FAILURE) | |||
There was a problem hiding this comment.
this also needs WC_NO_ERR_TRACE() now (tracing WOLFSSL_FAILURE was added in #7917).
| @@ -25557,7 +25557,7 @@ WOLFSSL_TEST_SUBROUTINE wc_test_ret_t openssl_test(void) | |||
| if (EVP_CIPHER_CTX_block_size(en) != en->block_size) | |||
| return WC_TEST_RET_ENC_NC; | |||
|
|
|||
| if (EVP_CIPHER_block_size(NULL) != WC_NO_ERR_TRACE(BAD_FUNC_ARG)) | |||
| if (EVP_CIPHER_block_size(NULL) != WOLFSSL_FAILURE) | |||
| if (EVP_CIPHER_CTX_set_padding(NULL, 0) != | ||
| WC_NO_ERR_TRACE(BAD_FUNC_ARG)) | ||
| { | ||
| if (EVP_CIPHER_CTX_set_padding(NULL, 0) != WOLFSSL_FAILURE) |
- RsaFunctionPrivate: detect when only n,e,d are available - wolfSSL_EVP_add_digest: return success - wolfSSL_EVP_add_cipher: return success - wolfSSL_BN_bin2bn: accept NULL data if len is 0 (checked in mp_read_unsigned_bin) - wolfssl_read_bio: advance correct bio - wolfSSL_X509_set_ext: return raw extension data for BASIC_CA_OID - Implement - sk_X509_EXTENSION_free - d2i_EC_PUBKEY_bio - d2i_RSA_PUBKEY_bio - d2i_X509_REQ_INFO - X509_REQ_INFO_free - ASN1_TIME_set_string_X509
julek-wolfssl
force-pushed
the
libspdm-x509
branch
from
07e9a60 to
2c9a3c5
Compare
douzzer
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.