Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conditional repository_owner to workflow #7871

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

gojimmypi
Copy link
Contributor

Description

This PR adds a workflow condition to only run the workflow on wolfssl-owned repositories (in this case, async.yml). I propose doing this on all workflows, but this PR is only for the first one to open a discussion and code review. I'm happy to make the changes for others.

Why?

I've recently begun implementing automated Espressif CI testing. One of the things that has been annoying and even problematic has been all the upstream workflows running in my fork, such as this sync from upstream:

image

Worse, some of them appear to never stop:

image

Although I think that's actually a GitHub bug, as the ones from last month are not actually running:

image

Fixes zd# n/a

Testing

How did you test?

not tested.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi
Copy link
Contributor Author

Update: thanks @julek-wolfssl for the tip on manually disabling workflows in a fork. That works, but I found it rather unintuitive.

I still think it's a good idea to not run all the upstream workflows by default. We could have contributors that may be time-limited on computing power or something. It just seems to be a waste. Thoughts?

@gojimmypi
Copy link
Contributor Author

Jenkins retest this please

Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good way to do this. Its still going to run just result in errors. This also adds unnecessary and unintuitive clutter to the actions. If you really want to I'm sure there is a way to disable the actions through the gh api and run that as cron job.

julek-wolfssl
julek-wolfssl previously approved these changes Aug 20, 2024
Copy link
Member

@julek-wolfssl julek-wolfssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been persuaded that this may have some merit.

@gojimmypi
Copy link
Contributor Author

Conditional Updates

After a discussion with @bandi13 I've updated all the wolfSSL workflows to conditionally run on:

if: github.repository_owner == 'wolfssl'

This condition was generally placed between the name: and runs-on: keywords.

socat_check update

I noticed a syntax highlighting error for the socat_check strategy (none was defined), so I removed it.

image

@JacobBarthelmeh
Copy link
Contributor

@bandi13 please review these changes to github action tests

Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct

@bandi13 bandi13 merged commit a1a3a0b into wolfSSL:master Sep 26, 2024
135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants