20240814-linuxkm-kyber-asm #7872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PENSSL_EXTRA gate. fixes test.c:certext_test(), broken by f8c968d for some valid configs.
…ics re checkedAESNI, haveAESNI, intel_flags, and sha_method. see wolfSSL#7863.
SparkiDev
requested changes
Aug 14, 2024
wolfcrypt/src/wc_kyber.c
Outdated
| at = (sword16*)XMALLOC(((kp + 3) * kp + 3) * KYBER_N * sizeof(sword16), | ||
| key->heap, DYNAMIC_TYPE_TMP_BUFFER); | ||
| #else | ||
| at = (sword16*)XMALLOC( | ||
| ((KYBER_MAX_K + 3) * KYBER_MAX_K + 3) * KYBER_N * sizeof(sword16), |
There was a problem hiding this comment.
Make them the allocation size the same as above.
KYBER_MAX_K -> kp
…te "at" for USE_INTEL_SPEEDUP.
SparkiDev
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linuxkm: add intelasm support for Kyber.
ASN: move
DecodedCert.extSubjKeyIdSzand.extAuthKeyIdSzout of theOPENSSL_EXTRAgate. fixestest.c:certext_test(), broken by f8c968d, detected by nightly scenarioslinuxkm-defaults-all-fips-140-3,linuxkm-defaults-all-fips-140-3-pilot,linuxkm-defaults-all-no-asm,linuxkm-defaults-all-intelasm, andall-linuxkm-defaults-error-code-openssl.add comments explaining dependence on idempotency for race-free dynamics re
checkedAESNI,haveAESNI,intel_flags, andsha_method. see #7863.tested with
wolfssl-multi-test.sh ... super-quick-check linuxkm-defaults-all-fips-140-3 linuxkm-defaults-all-no-asm all-g\\+\\+ quantum-safe-wolfssl-all-crypto-only-intelasm-sp-asm-linuxkm-insmod