POSIX does not request "date" command to support "-R" option. #7874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Okay to test. Approved contributor agreement is on file. |
douzzer
requested changes
Aug 17, 2024
mpsuzuki
added a commit
to mpsuzuki/wolfssl-patch-dev
that referenced
this pull request
Aug 18, 2024
…"date" with no extension. Following to the advice by Daniel Pouzzner (see the discussion in the issue wolfSSL#7874), no need to invoke "env" command to set LC_TIME. * IEEE Std 1003.1-2024 does not request the "-R" option: https://pubs.opengroup.org/onlinepubs/9799919799/ * Default "date" in Solaris 11.4 does not support "-R": https://docs.oracle.com/cd/E88353_01/html/E37839/date-1.html * Default "date" in HP-UX 11.22 does not support "-R": https://man.freebsd.org/cgi/man.cgi?query=date&apropos=0&sektion=0&manpath=HP-UX+11.22&arch=default&format=html * Default "date" in AIX 7 does not support "-R": https://www.ibm.com/docs/en/aix/7.3?topic=d-date-command
mpsuzuki
force-pushed
the
fix-posix-date
branch
from
d980e10
to
ca0e81f
Compare
…"date" with no extension. Following to the advice by Daniel Pouzzner (see the discussion in the issue wolfSSL#7874), no need to invoke "env" command to set LC_TIME. * IEEE Std 1003.1-2024 does not request the "-R" option: https://pubs.opengroup.org/onlinepubs/9799919799/ * Default "date" in Solaris 11.4 does not support "-R": https://docs.oracle.com/cd/E88353_01/html/E37839/date-1.html * Default "date" in HP-UX 11.22 does not support "-R": https://man.freebsd.org/cgi/man.cgi?query=date&apropos=0&sektion=0&manpath=HP-UX+11.22&arch=default&format=html * Default "date" in AIX 7 does not support "-R": https://www.ibm.com/docs/en/aix/7.3?topic=d-date-command
mpsuzuki
force-pushed
the
fix-posix-date
branch
from
30fcd55
to
e417091
Compare
douzzer
approved these changes
Aug 20, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently configure script sets WOLFSSL_BUILD_DATE by "date -R", like:
According to POSIX specification IEEE Std 1003.1-2024, "date" command can lack the "-R" option. In fact, online manuals for preinstalled "date" commands in some proprietary systems does not mention the "-R":
Setting locale to C (to prevent localized weekday name like "月" for Monday) and spelling-out the format can make "configure" more portable.