20240814-debug-trace-errcodes-MP #7875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
requested changes
Aug 15, 2024
douzzer
force-pushed
the
20240814-debug-trace-errcodes-MP
branch
from
6ca1981
to
558d3c1
Compare
SparkiDev
previously approved these changes
Aug 19, 2024
…wolfcrypt/tfm.h, and wolfssl/wolfcrypt/integer.h, to wolfssl/wolfcrypt/error-crypt.h, harmonizing their names and numbers. wolfssl/wolfcrypt/error-crypt.h: add WC_FIRST_E. wolfcrypt/src/error.c: add MP error code strings. wolfssl/error-ssl.h: add WOLFSSL_FIRST_E and WOLFSSL_LAST_E. wolfcrypt/test/test.c: update error_test() for new error code layout, refactoring the "missing" check. src/internal.c: use WC_FIRST_E and WC_LAST_E in wolfSSL_ERR_reason_error_string(). src/ssl.c: fix wolfSSL_ERR_GET_REASON() to identify in-range error codes using WC_FIRST_E, WC_LAST_E, WOLFSSL_FIRST_E, and WOLFSSL_LAST_E. sp_int.h: provide for WOLFSSL_DEBUG_TRACE_ERROR_CODES, and refactor MP error codes as enums, for consistency with other error codes. wolfcrypt/src/ecc.c: fix 2 identicalInnerCondition's.
douzzer
force-pushed
the
20240814-debug-trace-errcodes-MP
branch
5 times, most recently
from
77c5aab
to
6a227c8
Compare
…-100} to avoid collisions.
douzzer
force-pushed
the
20240814-debug-trace-errcodes-MP
branch
from
6a227c8
to
2448d48
Compare
bandi13
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Good call on moving the error codes to 'error-crypt.h'. I still think since we are changing the values of MP constants we should collapse MP_MEM to MEMORY_E and MP_VAL to BAD_FUNC_ARG. I do understand the concern of collapsing error codes causing potential problems.
SparkiDev
approved these changes
Aug 22, 2024
|
MP_VAL at least gives us the information that the error was in the maths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move several MP error codes from
wolfssl/wolfcrypt/sp_int.h,wolfssl/wolfcrypt/tfm.h, andwolfssl/wolfcrypt/integer.h, towolfssl/wolfcrypt/error-crypt.h, harmonizing their names and numbers.wolfssl/wolfcrypt/error-crypt.h: addWC_FIRST_E.wolfcrypt/src/error.c: add MP error code strings.wolfssl/error-ssl.h: addWOLFSSL_FIRST_EandWOLFSSL_LAST_E.wolfcrypt/test/test.c: updateerror_test()for new error code layout, refactoring the "missing" check.src/internal.c: useWC_FIRST_EandWC_LAST_EinwolfSSL_ERR_reason_error_string().src/ssl.c: fixwolfSSL_ERR_GET_REASON()to identify in-range error codes usingWC_FIRST_E,WC_LAST_E,WOLFSSL_FIRST_E, andWOLFSSL_LAST_E.wolfcrypt/src/ecc.c: fix 2identicalInnerCondition's.note, refactoring the sp error codes as enums adds helpful additional error checking by the compiler, and also helped
cppcheckuncover the benign-but-trueidenticalInnerConditions.tested with
wolfssl-multi-test.sh ... super-quick-check int-math all-enable-fastmathwith the latter 2 tweaked to add--enable-debug-trace-errcodes.