-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dilithum, Kyber: Update to final specification #7877
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
force-pushed
the
ml_dsa_ml_kem_final
branch
2 times, most recently
from
August 19, 2024 08:51
40472e7
to
a2c1e26
Compare
SparkiDev
force-pushed
the
ml_dsa_ml_kem_final
branch
3 times, most recently
from
August 21, 2024 03:17
4da4f45
to
c7fcca2
Compare
@SparkiDev Since #7807 has already been merged, this PR should also incorporate the move from |
retest this please |
douzzer
requested changes
Aug 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(test results sent separately)
SparkiDev
force-pushed
the
ml_dsa_ml_kem_final
branch
from
August 26, 2024 07:41
c7fcca2
to
cf7be6c
Compare
FIPS 203 and FIPS 204 final specification changes.
SparkiDev
force-pushed
the
ml_dsa_ml_kem_final
branch
from
August 26, 2024 07:42
cf7be6c
to
60f438f
Compare
Made fixes from test results. |
douzzer
approved these changes
Aug 26, 2024
anhu
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FIPS 203 and FIPS 204 final specification changes.
Testing
Regression test Kyber and Dilithium.
Checklist