Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dilithum, Kyber: Update to final specification #7877

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

SparkiDev
Copy link
Contributor

Description

FIPS 203 and FIPS 204 final specification changes.

Testing

Regression test Kyber and Dilithium.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Aug 15, 2024
@SparkiDev SparkiDev marked this pull request as draft August 15, 2024 11:55
@SparkiDev SparkiDev force-pushed the ml_dsa_ml_kem_final branch 2 times, most recently from 40472e7 to a2c1e26 Compare August 19, 2024 08:51
@SparkiDev SparkiDev marked this pull request as ready for review August 19, 2024 10:52
@SparkiDev SparkiDev force-pushed the ml_dsa_ml_kem_final branch 3 times, most recently from 4da4f45 to c7fcca2 Compare August 21, 2024 03:17
@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Aug 21, 2024
@SparkiDev SparkiDev requested a review from wolfSSL-Bot August 21, 2024 04:15
@Frauschi
Copy link
Contributor

@SparkiDev Since #7807 has already been merged, this PR should also incorporate the move from WOLFSSL_ML_KEM to WOLFSSL_KYBER_ORIGINAL" in the wolfssl/ssl.h header file.

@douzzer
Copy link
Contributor

douzzer commented Aug 23, 2024

retest this please

Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(test results sent separately)

@douzzer douzzer assigned SparkiDev and unassigned wolfSSL-Bot Aug 24, 2024
@SparkiDev SparkiDev force-pushed the ml_dsa_ml_kem_final branch from c7fcca2 to cf7be6c Compare August 26, 2024 07:41
FIPS 203 and FIPS 204 final specification changes.
@SparkiDev SparkiDev force-pushed the ml_dsa_ml_kem_final branch from cf7be6c to 60f438f Compare August 26, 2024 07:42
@SparkiDev
Copy link
Contributor Author

Made fixes from test results.

@anhu anhu merged commit bf074d2 into wolfSSL:master Aug 26, 2024
127 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants