Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240819-shebang-bash-env #7886

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

douzzer
Copy link
Contributor

@douzzer douzzer commented Aug 19, 2024

portability enhancement: use #!/usr/bin/env <interpreter> on all perl scripts and shell scripts that use bash extensions, and use "#!/bin/sh" on the rest.

tested with wolfssl-multi-test.sh ... check-shell-scripts

note that shellcheck is smart enough to decipher the correct shell dialect from shebangs that use /usr/bin/env.

I used shellcheck -s sh --severity=warning to identify scripts that can use POSIX #!/bin/sh.

@dgarske
Copy link
Contributor

dgarske commented Aug 20, 2024

Related to #7878

@julek-wolfssl julek-wolfssl linked an issue Aug 20, 2024 that may be closed by this pull request
@julek-wolfssl
Copy link
Member

What about the perl shebangs?

@douzzer
Copy link
Contributor Author

douzzer commented Aug 20, 2024

Quite right! Thanks @julek-wolfssl for the reminder -- will update the perl shebangs too, and search for any other missed spots.

…rl scripts and shell scripts that use bash extensions, and use "#!/bin/sh" on the rest.
@SparkiDev
Copy link
Contributor

retest this please

@SparkiDev SparkiDev merged commit 2505a59 into wolfSSL:master Aug 21, 2024
123 of 125 checks passed
@mpsuzuki
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

more portable shebang for Bash and Perl script
5 participants