Use verify callback before checking dates #7895
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
wolfSSL_X509_verify_cert
, after an error has been set is can be overwritten by the subsequent date check. If the callback is being used to override date errors, then the invalid cert gets treated as verified. This change adds a call to the verify callback before the date check. This way the application can handle the error(s) appropriately.Fixes zd18433
Testing
Set system time to before cert validity of
./certs/intermediate/ca-int2-cert.pem
. CallX509_verify_cert
, similar totest_X509_STORE_untrusted_certs
test. Observe ASN_SIGNER_ERROR being overwritten with date error.Checklist