Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new crypto callback for RSA with padding. #7907

Merged
merged 5 commits into from
Sep 5, 2024

Conversation

ColtonWilley
Copy link
Contributor

Description

Adds a new crypto callback for RSA with padding. The new callback optionally handles RSA padding itself, while maintaining existing fallback models.

@dgarske dgarske self-requested a review August 27, 2024 20:14
@ColtonWilley
Copy link
Contributor Author

Retest this please.

Copy link
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested with a PKCS#11 implementation?

tests/api.c Show resolved Hide resolved
wolfcrypt/src/wc_pkcs11.c Show resolved Hide resolved
wolfcrypt/src/wc_pkcs11.c Outdated Show resolved Hide resolved
@ColtonWilley
Copy link
Contributor Author

Yes, this has been tested against softHSM.

@SparkiDev
Copy link
Contributor

SparkiDev commented Aug 29, 2024

Please add examples into wolfssl-examples/pkcs11.
Add a link to the PR here.

…ack, code cleanup to address review comments.
SparkiDev
SparkiDev previously approved these changes Sep 2, 2024
@SparkiDev SparkiDev removed their assignment Sep 2, 2024
@dgarske
Copy link
Contributor

dgarske commented Sep 4, 2024

Retest this please. History lost, too old

@ColtonWilley
Copy link
Contributor Author

@SparkiDev I have added a PSS example to the PKCS11 examples, the rest of the code did not need to be modified.

wolfSSL/wolfssl-examples#456

Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over to @SparkiDev

@SparkiDev SparkiDev merged commit 96e2c51 into wolfSSL:master Sep 5, 2024
129 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants