Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for (DevkitPro)libnds #7990

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

buchstabenwurst
Copy link
Contributor

@buchstabenwurst buchstabenwurst commented Sep 18, 2024

Description

Added support for libnds from DevkitPro.

Testing

How did you test?

With the configuration as written in ./IDE/NDS/README.md

  • Real Hardware
  • MelonDS Emulator

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@embhorn
Copy link
Member

embhorn commented Sep 18, 2024

Hi @buchstabenwurst

Thanks for your proposed changes. We require having a contributor agreement on file to accept changes from outside sources. I can help you get started if you email support@wolfssl.com and mention this PR.

Kind regards,
Eric - wolfSSL Support

@embhorn embhorn self-assigned this Sep 18, 2024
@dgarske
Copy link
Contributor

dgarske commented Sep 23, 2024

Hi @buchstabenwurst , your contributor agreement has been approved. Okay to test.

@dgarske dgarske assigned wolfSSL-Bot and unassigned embhorn Sep 23, 2024
wolfcrypt/test/test.c Show resolved Hide resolved
wolfcrypt/test/test.c Show resolved Hide resolved
dgarske
dgarske previously approved these changes Sep 24, 2024
wolfssl/wolfcrypt/settings.h Outdated Show resolved Hide resolved
@JacobBarthelmeh
Copy link
Contributor

Retest this please Jenkins, the fail reason was not captured before the logs were erased.

@JacobBarthelmeh
Copy link
Contributor

Errors reported with CI are not related to these code changes. Thanks for the contribution.

@JacobBarthelmeh JacobBarthelmeh merged commit d72c0b3 into wolfSSL:master Sep 25, 2024
134 of 135 checks passed
@jackctj117
Copy link

@buchstabenwurst how were you able to read in the certs for the wolfcrypt test?

@buchstabenwurst
Copy link
Contributor Author

@buchstabenwurst how were you able to read in the certs for the wolfcrypt test?

I copied the certs directory to _nds/certs on the sd card of the ds.

@jackctj117
Copy link

@buchstabenwurst how were you able to read in the certs for the wolfcrypt test?

I copied the certs directory to _nds/certs on the sd card of the ds.

I was able to get it to work but I had to remove fat:/ from #define CERT_PREFIX "fat:/_nds/" in order for MelonDS to read in the certs. Will this change the functionality when using physical hardware?

@buchstabenwurst
Copy link
Contributor Author

@buchstabenwurst how were you able to read in the certs for the wolfcrypt test?

I copied the certs directory to _nds/certs on the sd card of the ds.

I was able to get it to work but I had to remove fat:/ from #define CERT_PREFIX "fat:/_nds/" in order for MelonDS to read in the certs. Will this change the functionality when using physical hardware?

This will work the same, the fat: is for compatability when using fat and nitrofs together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants