-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240917-fixes #7991
Merged
Merged
20240917-fixes #7991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfssl/wolfcrypt/wc_port.h: add WOLFSSL_API attribute to wolfSSL_Atomic_Int_Init, wolfSSL_Atomic_Int_FetchAdd, and wolfSSL_Atomic_Int_FetchAdd, and add fallback definitions for them, allowing elimination of SINGLE_THREADED implementations of wolfSSL_Ref*(), and allowing ungated use of wolfSSL_Atomic_* calls in api.c. wolfcrypt/src/dh.c: in wc_DhAgree_ct(), remove frivolous XMEMSET() and stray semicolon. wolfcrypt/benchmark/benchmark.c: fix bench_rsaKeyGen() to skip tests of key sizes below RSA_MIN_SIZE, and add 4096 bit benchmark if RSA_MAX_SIZE is big enough. tests/unit.h: * adopt definitions of TEST_FAIL, TEST_SUCCESS, and TEST_SKIPPED from unit.c, remap TEST_SKIPPED from -7777 to 3, and add TEST_SUCCESS_NO_MSGS, TEST_SKIPPED_NO_MSGS, EXPECT_DECLS_NO_MSGS(), and EXPECT_FAILURE_CODEPOINT_ID, to support existing and future expected-particular-failure test cases without log noise. * rename outer gate from CyaSSL_UNIT_H to TESTS_UNIT_H. tests/api.c: * use EXPECT_DECLS_NO_MSGS() in test_ssl_memio_setup(), test_ssl_memio_read_write(), and test_wolfSSL_client_server_nofail_memio(), and globally update affected expected error codes to correspond. * use atomics for {client,server}SessRemCount{Malloc,free} to fix races in SessRemCtxCb() and SessRemSslSetupCb().
douzzer
force-pushed
the
20240917-fixes
branch
from
September 18, 2024 21:27
3258a9c
to
072c531
Compare
…deref reported by clang-tidy in FIPS/Async configs.
douzzer
force-pushed
the
20240917-fixes
branch
from
September 19, 2024 02:02
0bfe7f3
to
9f980c8
Compare
retest this please. |
wolfssl/internal.h: add DTLS13_HANDSHAKE_HEADER_SZ; src/tls13.c: in EchHashHelloInner(), use falseHeader[DTLS13_HANDSHAKE_HEADER_SZ] to fix buffer overrun; src/dtls13.c: add static assert for DTLS13_HANDSHAKE_HEADER_SZ.
douzzer
force-pushed
the
20240917-fixes
branch
from
September 19, 2024 06:16
9f980c8
to
fbbb2b8
Compare
retest this please |
…itions, and add static_assert2().
SparkiDev
requested changes
Sep 19, 2024
…d ecc_sets_count using accessor functions, to fix linker relocation errors in Fedora packaging test.
douzzer
force-pushed
the
20240917-fixes
branch
from
September 19, 2024 22:11
147a49b
to
da1b835
Compare
…edora packaging test: always export ECC_API functions, but when !WOLFSSL_PUBLIC_ECC_ADD_DBL, remap them with wc_ prefixes.
…ors in Fedora packaging test: always export ECC_API functions, but when !WOLFSSL_PUBLIC_ECC_ADD_DBL, remap them with wc_ prefixes." This reverts commit a31e914.
SparkiDev
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/types.h
: addstatic_assert()
definitions;wolfssl/internal.h
: addDTLS13_HANDSHAKE_HEADER_SZ
;src/tls13.c
: inEchHashHelloInner()
, usefalseHeader[DTLS13_HANDSHAKE_HEADER_SZ]
to fix buffer overrun;src/dtls13.c
: add static assert forDTLS13_HANDSHAKE_HEADER_SZ
.tests/api.c
:test_Sha512_Family_Final()
: fix unreachable null pointer deref reported by clang-tidy in FIPS/Async configs.m4/ax_atomic.m4
: fixes for C++ compatibility.wolfssl/wolfcrypt/wc_port.h
: addWOLFSSL_API
attribute towolfSSL_Atomic_Int_Init
,wolfSSL_Atomic_Int_FetchAdd
, andwolfSSL_Atomic_Int_FetchAdd
, and add fallback definitions for them, allowing elimination ofSINGLE_THREADED
implementations ofwolfSSL_Ref*()
, and allowing ungated use ofwolfSSL_Atomic_*
calls inapi.c
.wolfcrypt/src/dh.c
: inwc_DhAgree_ct()
, remove frivolousXMEMSET()
and stray semicolon.wolfcrypt/benchmark/benchmark.c
: fixbench_rsaKeyGen()
to skip tests of key sizes belowRSA_MIN_SIZE
, and add 4096 bit benchmark ifRSA_MAX_SIZE
is big enough.tests/unit.h
:TEST_FAIL
,TEST_SUCCESS
, andTEST_SKIPPED
fromunit.c
, remapTEST_SKIPPED
from-7777
to3
, and addTEST_SUCCESS_NO_MSGS
,TEST_SKIPPED_NO_MSGS
,EXPECT_DECLS_NO_MSGS()
, andEXPECT_FAILURE_CODEPOINT_ID
, to support existing and future expected-particular-failure test cases without log noise.CyaSSL_UNIT_H
toTESTS_UNIT_H
.tests/api.c
:EXPECT_DECLS_NO_MSGS()
intest_ssl_memio_setup()
,test_ssl_memio_read_write()
, andtest_wolfSSL_client_server_nofail_memio()
, and globally update affected expected error codes to correspond.{client,server}SessRemCount{Malloc,free}
to fix races inSessRemCtxCb()
andSessRemSslSetupCb()
.tested with
wolfssl-multi-test.sh ... super-quick-check