Implement DTLS 1.2 Connection ID (CID) #7995
Open
+1,107
−702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
force-pushed
the
dtls12-cid
branch
2 times, most recently
from
4841486
to
d7ab338
Compare
|
Retest this please. |
rizlik
requested changes
Sep 20, 2024
rizlik
reviewed
Sep 20, 2024
|
|
julek-wolfssl
force-pushed
the
dtls12-cid
branch
from
5d3b842
to
bf946d2
Compare
julek-wolfssl
force-pushed
the
dtls12-cid
branch
from
bf946d2
to
cf96ab2
Compare
JacobBarthelmeh
requested changes
Sep 23, 2024
There was a problem hiding this comment.
I'd like to have one more person review this pull request too.
When trying to build using the configure :./configure --enable-dtls --enable-dtlscid --enable-dtls13
tests/api.c:94360:25: error: implicit declaration of function ‘wolfSSL_Rehandshake’; did you mean ‘wolfSSL_BIO_do_handshake’? [-Werror=implicit-function-declaration]
94360 | ExpectIntEQ(wolfSSL_Rehandshake(ssl_c), -1);
| ^~~~~~~~~~~~~~~~~~~
./tests/unit.h:188:24: note: in definition of macro ‘ExpectInt’
Adding secure-renegotiation ./configure --enable-dtls --enable-dtlscid --enable-dtls13 --enable-secure-renegotiation results in :
911: test_dtls_old_seq_number : passed ( 0.00351)
912: test_dtls12_basic_connection_id :
Testing AES128-SHA256 run #0 ...
ERROR - tests/api.c line 94241 failed with:
expected: wolfSSL_set_cipher_list(ssl_c, params[i]) == 1
result: 0 != 1
failed
Testing AES128-SHA256 run #1 ... failed
|
retest this please |
JacobBarthelmeh
approved these changes
Sep 25, 2024
|
@SparkiDev please give this an additional review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.