20240920-fixes #7999
Merged
20240920-fixes #7999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure.ac: * fix logic in "Forcing off" test expressions, first flubbed in 19106a9; * fix auto-enable of compkey to exclude v5 even if v5-dev. src/tls13.c: fix gating for HKDF _ex() variants (>=6.0, not >=5.3). wolfcrypt/src/error.c: snip out stray spaces at start of several ECC error message strings. wolfcrypt/test/test.c: * in render_error_message(), use wolfSSL_ERR_reason_error_string() if available rather than wc_GetErrorString(), to render non-wolfcrypt error strings; * in ecc_test_deterministic_k(), ecc384_test_deterministic_k(), ecc521_test_deterministic_k(), on FIPS <6.0, gate out SHA384 and SHA512 tests (FIPS v5 only supports SHA256 in wc_ecc_gen_deterministic_k()); * in cmac_test(), gate use of wc_AesCmacGenerate_ex() and wc_AesCmacVerify_ex() on >=6.0, not >=5.3.
douzzer
force-pushed
the
20240920-fixes
branch
from
27f8726
to
55cd8a8
Compare
|
retest this please ( |
kaleb-himes
approved these changes
Sep 20, 2024
JacobBarthelmeh
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS v5 gating fixes:
configure.ac:v5-dev.src/tls13.c: fix gating for HKDF _ex() variants (>=6.0, not >=5.3);wolfcrypt/src/error.c: snip out stray spaces at start of several ECC error message strings;wolfcrypt/test/test.c:render_error_message(), usewolfSSL_ERR_reason_error_string()if available rather thanwc_GetErrorString(), to render non-wolfcrypt error strings;ecc_test_deterministic_k(),ecc384_test_deterministic_k(),ecc521_test_deterministic_k(), on FIPS <6.0, gate out SHA384 and SHA512 tests (FIPS v5 only supports SHA256 inwc_ecc_gen_deterministic_k());cmac_test(), gate use ofwc_AesCmacGenerate_ex()andwc_AesCmacVerify_ex()on >=6.0, not >=5.3.tested with
wolfssl-multi-test.sh ... fips-140-3-v5-ready-optest-acvp-sp-asm fips-140-3-v5-dev-all fips-140-3-dev-kcapi super-quick-check