-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to separate CMAC and AES conditional compiles. Correct update. #8007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but consider adding compile error for non-AES enabled CMAC builds for now, unless that was deliberate to facilitate a cryptocb only approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failing on clang-tidy
/tmp/workspace/PRB-multi-test-script/wolfssl/wolfcrypt/src/cmac.c:302:5: warning: Value stored to 'ret' is never read [clang-analyzer-deadcode.DeadStores]
ret = 0;
^ ~
/tmp/workspace/PRB-multi-test-script/wolfssl/wolfcrypt/src/cmac.c:302:5: note: Value stored to 'ret' is never read
ret = 0;
^ ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice cleanups here. Just a minor item. Not required to fix, but it might improve things.
Description
This provides a few cryptocb and CMAC updates:
Note that for proper functionality with AES CMAC, the defines WOLFSSL_CMAC, WOLFSSL_AES_DIRECT must be set, while NO_AES cannot be set. This matches current functionality.
Testing
Checklist