asn: cleanup around edPubKeyASN. #8009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anhu
reviewed
Sep 24, 2024
| @@ -12015,34 +12015,38 @@ int wc_EccPublicKeyDerSize(ecc_key* key, int with_AlgCurve) | |||
|
|
|||
| #ifdef WOLFSSL_ASN_TEMPLATE | |||
| #if defined(WC_ENABLE_ASYM_KEY_EXPORT) || defined(WC_ENABLE_ASYM_KEY_IMPORT) | |||
| /* ASN.1 template for Ed25519 and Ed448 public key (SubkectPublicKeyInfo). | |||
| /* ASN.1 template for the SubjectPublicKeyInfo of a general asymmetric key. | |||
| * Used with Ed448/Ed25519, Curve448/Curve25519, sphincs, falcon, dilithium, | |||
|
Retest this please |
JacobBarthelmeh
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup var names and comments around
SetAsymKeyDerPublic()to better match current usage.Renamed:
edPubKeyASN->publicKeyASNedPubKeyASN_Length->publicKeyASN_LengthEDPUBKEYASN_IDX_SEQ->PUBKEYASN_IDX_SEQ