Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM64 to Visual Studio Project #8010

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

res0nance
Copy link
Contributor

Description

With ARM64 support being more prevalent on Windows lets add it to the VS project to make it easier to compile for ARM64 support.

Testing

Compile tested and new compile testing on CI

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Sep 24, 2024

Very nice PR! Thank you @res0nance . I see you have a contributor agreement on file. Jenkins Okay to test.
Thanks, David Garske, wolfSSL

Copy link
Contributor

@bandi13 bandi13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. On Windows, there is a ARM64 platform that it could run on that was recently released. We can get that going once this is merged.

Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested compiling, thanks for adding the GitHub action.

@JacobBarthelmeh JacobBarthelmeh merged commit 72711b4 into wolfSSL:master Sep 24, 2024
137 checks passed
@res0nance res0nance deleted the win-arm64-support branch September 25, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants