Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory: fix types in wc_LoadStaticMemory_ex() #8117

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

rizlik
Copy link
Contributor

@rizlik rizlik commented Oct 28, 2024

Description

Fix to use the right array type in wc_LoadStaticMemory_ex()

@rizlik
Copy link
Contributor Author

rizlik commented Oct 28, 2024

retest this please

@rizlik rizlik marked this pull request as ready for review October 28, 2024 22:02
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few more locations that need touched to make all sizeList and distList be an array of word32's

  • wolfssl/wolfcrypt/memory.h, line 222
  • wolfssl/wolfcrypt/memory.h, line 260
  • wolfssl/wolfcrypt/memory.h, line 284
  • wolfcrypt/src/memory.c, line 672
  • wolfcrypt/src/memory.c, line 820

@rizlik
Copy link
Contributor Author

rizlik commented Nov 4, 2024

There's a few more locations that need touched to make all sizeList and distList be an array of word32's

* wolfssl/wolfcrypt/memory.h, line 222

* wolfssl/wolfcrypt/memory.h, line 260

* wolfssl/wolfcrypt/memory.h, line 284

* wolfcrypt/src/memory.c, line 672

* wolfcrypt/src/memory.c, line 820

completely missed them. Thanks

@JacobBarthelmeh
Copy link
Contributor

Retest this please Jenkins. I missed capturing what the failure was.

@rizlik rizlik assigned wolfSSL-Bot and JacobBarthelmeh and unassigned rizlik Nov 11, 2024
@JacobBarthelmeh JacobBarthelmeh merged commit 4996aed into wolfSSL:master Nov 11, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants