-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Curve25519 generic keyparsing #8129
Merged
SparkiDev
merged 5 commits into
wolfSSL:master
from
bigbrett:curve25519-generic-keyparsing
Oct 31, 2024
Merged
Curve25519 generic keyparsing #8129
SparkiDev
merged 5 commits into
wolfSSL:master
from
bigbrett:curve25519-generic-keyparsing
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
previously approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Over to @SparkiDev
SparkiDev
requested changes
Oct 31, 2024
SparkiDev
previously requested changes
Oct 31, 2024
@dgarske @SparkiDev addressed all feedback |
dgarske
approved these changes
Oct 31, 2024
SparkiDev
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work by the way.
Thanks @SparkiDev! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds API for curve25519
der
import/export that can handle both private and public keys in one step. I realize that typically curve25519 keys are distributed as public/private only, since you can recover the public key from the private key, but this API simplifies usage for some cases in that it doesn't require multiple import attempts if you don't know at runtime what the contents of ader
key holds.This API is particularly useful for wolfHSM, where the server doesn't know what the contents of a
DER
key contain when it loads/stores from NVM, but needs to import the key into acurve25519_key
struct that then will have the proper public/private key fields set. The current API doesn't provide a straightforward way to do this.Added doxygen, and will update the manual/docs once this merges
Testing
Checklist