Detect 'isascii' at configuration stage #8158
Open
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously platforms without isascii had to manually indicate it's absence with `NO_STDLIB_ISASCII` define. It is trivial to detect function availability, so do that.
|
Can one of the admins verify this patch? |
redbaron
commented
Nov 7, 2024
| @@ -2504,7 +2504,6 @@ extern void uITRON4_free(void *p) ; | |||
| #define WOLFSSL_DH_CONST | |||
| #define WOLFSSL_HAVE_MAX | |||
| #define NO_WRITEV | |||
| #define NO_STDLIB_ISASCII | |||
There was a problem hiding this comment.
It just occurred to me, that HAVE_ISASCII is stored in config.h which is optional. Maybe this define should stay as is?
|
@redbaron is approved as a wolfSSL contributor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detect 'isascii' at configuration stage
Previously platforms without isascii had to manually
indicate it's absence with
NO_STDLIB_ISASCIIdefine.It is trivial to detect function availability, so do that.
Testing
Built on platform with no
isasciiavailableChecklist