Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct cmake script to support Open Watcom toolchain #8167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmalak
Copy link

@jmalak jmalak commented Nov 8, 2024

Description

CMake build by Open Watcom toolchain failed due to -Wall option
Open Watcom doesn't support -Wall option it uses -wx instead
-wcd=202 option suppress message about unreferenced functions

Testing

Run WolfSSL CMake build with Open Watcom toolchain
It will not report incorrect -Wall option

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske
Copy link
Contributor

dgarske commented Nov 8, 2024

Hi @jmalak ,

Can you tell us more about your project and interest in our library? I recently worked with a customer for Watcom-C compiler support, but I did not try it with CMake.

We do require a contributor agreement to be in place to accept code changes. We could treat this as a bug report if that becomes an issue. Are you planning additional pull requests?

Thanks, David Garske, wolfSSL

@jmalak
Copy link
Author

jmalak commented Nov 8, 2024

Hi @jmalak ,

Can you tell us more about your project and interest in our library? I recently worked with a customer for Watcom-C compiler support, but I did not try it with CMake.

The main interest is to compile WolfSSL by Open Watcom toolchain, because OpenSSL is too much non-standard and requires many patches to do it working with Open Watcom. I thing that WolfSSL is more suitable to port to Open Watcom with much smaller number of changes. It should enable Open Watcom users to use WolfSSL for theirs applications. Main interest is build for Linux/Windows/OS/2 targets.
Because Open Watcom make system is different from Microsoft an GNU, existing WolfSSL make files can not be used for Open Watcom build without big changes.
Therefore simplest method to build WolfSSL is to use WolfSSL CMake support because Open Watcom toolchain is fully supported by CMake for all target OSEs (Linux/Windows/OS/2 and others).

We do require a contributor agreement to be in place to accept code changes. We could treat this as a bug report if that becomes an issue. Are you planning additional pull requests?

Yes I am planning to do more pull requests because in WolfSSL are some incompatibilities with Open Watcom which will requires small changes by example for Windows thread support.

Please If you need some agreement then give me some link to info how to process.
Thanks
Jiri Malak

@dgarske
Copy link
Contributor

dgarske commented Nov 8, 2024

Hi @jmalak ,

That's wonderful! To start the process of becoming an approved contributor please email support@wolfssl.com and refernce a link to this PR and include your country of residence.

Thanks,
David Garske, wolfSSL

@jmalak jmalak force-pushed the cmake branch 6 times, most recently from 0d523d3 to 6acec23 Compare November 9, 2024 06:17
Open Watcom doesn't support -Wall it uses -wx instead
-wcd=202 suppress message about unreferenced functions
@jmalak
Copy link
Author

jmalak commented Nov 9, 2024

Sorry, I put some WIP into this branch. Now it is corrected.

@kareem-wolfssl
Copy link
Contributor

ok to test

@bandi13
Copy link
Contributor

bandi13 commented Nov 12, 2024

retest this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants