Bump Gradle wrapper to 8.8

[wzieba]

Description

This PR bumps Gradle wrapper to 8.8.

Testing information

CI checks should be just fine.

• I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	e66afb9
	Direct Download	woocommerce-wear-prototype-build-pr11778-e66afb9.apk

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	e66afb9
	Direct Download	woocommerce-prototype-build-pr11778-e66afb9.apk

[ParaskP7]

👋 @wzieba !

I have reviewed this PR, everything works as expected, good job! 🌟

I also tested this with included builds (local-builds.gradle) and everything seems to be working as expected. ✅

Btw, why are we doing this update now, I am just trying to understand whether there was a need for that, for security purposes maybe, or whether this was done purely to keep our tooling up-to-date, and maybe, to also have Gradle prepared for a future AGP update? 🤔

---

I have left a question (❓) for you to consider. I am going to approve this PR anyway, since none is blocking. I am NOT going to merge this PR yet to give you some time to apply any of my suggestions. However, feel free to ignore them and merge the PR yourself.

---

EXTRAS

1. I issued another such update command and it gave me an updated gradlew and gradlew-wrapper.jar file. Can you try it again on your side and see if you also are getting these file to be re-updated, just like it happens on my side? 🙏

FYI: I used the following command:
./gradlew wrapper --gradle-version=8.8 --distribution-type=bin --gradle-distribution-sha256-sum=a4b4158601f8636cdeeab09bd76afb640030bb5b144aafe261a5e8af027dc612

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 19.4. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wzieba]

Btw, why are we doing this update now, I am just trying to understand whether there was a need for that, for security purposes maybe, or whether this was done purely to keep our tooling up-to-date, and maybe, to also have Gradle prepared for a future AGP update? 🤔

It's a preparation for AGP update, but also a casual dependency update. I think that we were usually combining AGP and Gradle updates, but there's no need to not update Gradle separately and more often.

I issued another such update command and it gave me an updated gradlew and gradlew-wrapper.jar file. Can you try it again on your side and see if you also are getting these file to be re-updated, just like it happens on my side? 🙏

I've doubled check and there's no difference for my gradlew and gradlew-wrapper.jar files. Also, I think "Validate Gradle Wrapper" should throw an error if these files were not precisely as they intend to be 🤔 . Could you please double check if there's still a diff when you run wrapper task?

[ParaskP7]

It's a preparation for AGP update, but also a casual dependency update. I think that we were usually combining AGP and Gradle updates, but there's no need to not update Gradle separately and more often.

I agree, maybe in the past, with some major updates, we had to do both, but unless we do have to do both, let's always do Gradle in isolation, and only then follow-up on AGP updates. 💯

I've doubled check and there's no difference for my gradlew and gradlew-wrapper.jar files. Also, I think "Validate Gradle Wrapper" should throw an error if these files were not precisely as they intend to be 🤔 . Could you please double check if there's still a diff when you run wrapper task?

Yea, I did double and triple check that, me running ./gradlew wrapper --gradle-version=8.8 ... will always produce a new diff. On the gradlew side it is just a comment change (can be ignored I guess), but on the gradlew-wrapper.jar side I am also seeing some code changes (can't be too much ignored). 🤔

I wonder why I get a diff and you don't, this is so strange and unpredictable, and imagine, we both use a Mac... 🤷

---

FYI: I don't want to block the merge so feel free to merge this anyway. 😊

PS: Same for WPAndroid.

[wzieba]

Yea, I did double and triple check that, me running ./gradlew wrapper --gradle-version=8.8 ... will always produce a new diff.

This is concerning 😕 - could you please prepare a PR (or only branch) with the diff? I'd like to examine the difference.

[ParaskP7]

Sure thing @wzieba I just did that and pushed this commit here on this bump_gradle_wrapper_petros branch. 👍

Let me know if that helps. 🙏

[wzieba]

So both versions are safe:

From this PR:

From your commit

But comparing this to https://gradle.org/release-checksums/, it looks like my update updated jar to version 8.6 🤨 The difference is that I used local gradle installed and I have it in version 8.6. But it shouldn't matter, as the task parameters point to 8.8.

I'll go ahead and cherry-pick your commit and merge this PR.

[ParaskP7]

...it looks like my update updated jar to version 8.6 🤨

Oh, interesting, and I was wondering what was happening there, thanks for sharing! 😅

I'll go ahead and cherry-pick your commit and merge this PR.

🚀