Merge pull request #68 from piotrbelina/feature/fix-invalid-resource-…

…id-2.0 Fixed invalid resource id
woohoolabs · Jan 31, 2018 · 003025e · 003025e
2 parents 7bf6a6e + a320d17
commit 003025e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/JsonApi/Exception/ResourceIdInvalid.php b/src/JsonApi/Exception/ResourceIdInvalid.php
@@ -13,7 +13,7 @@ class ResourceIdInvalid extends JsonApiException
      */
     protected $id;
 
-    public function __construct(string $id)
+    public function __construct($id)
     {
         parent::__construct("The resource ID '$id' must be a string!");
         $this->id = $id;

diff --git a/tests/JsonApi/Exception/ResourceIdInvalidTest.php b/tests/JsonApi/Exception/ResourceIdInvalidTest.php
@@ -19,7 +19,18 @@ public function getId()
         $this->assertEquals($id, $exception->getId());
     }
 
-    private function createException(string $id): ResourceIdInvalid
+    /**
+     * @test
+     */
+    public function createExceptionForNotString()
+    {
+        $id = 1;
+
+        $exception = $this->createException($id);
+        $this->assertEquals($id, $exception->getId());
+    }
+
+    private function createException($id): ResourceIdInvalid
     {
         return new ResourceIdInvalid($id);
     }