fix: 네이밍 변경 누락 오류 수정 및 네이밍 통일성 준수 (#470)

woowacourse-teams · Sep 20, 2023 · c26bd75 · c26bd75
1 parent d2dabd4
commit c26bd75
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/frontend/src/components/AuthorityRadioContainer/index.tsx b/frontend/src/components/AuthorityRadioContainer/index.tsx
@@ -19,7 +19,7 @@ interface AuthorityRadioContainer {
   isPublic: boolean;
   authorizedMemberIds: number[];
   setIsPrivate: React.Dispatch<React.SetStateAction<boolean>>;
-  setIsAll: React.Dispatch<React.SetStateAction<boolean>>;
+  setIsPublic: React.Dispatch<React.SetStateAction<boolean>>;
   setAuthorizedMemberIds: React.Dispatch<React.SetStateAction<number[]>>;
   permissionedMembers?: TopicAuthorMemberWithAuthorId[];
 }
@@ -29,7 +29,7 @@ const AuthorityRadioContainer = ({
   isPublic,
   authorizedMemberIds,
   setIsPrivate,
-  setIsAll,
+  setIsPublic,
   setAuthorizedMemberIds,
   permissionedMembers,
 }: AuthorityRadioContainer) => {
@@ -51,13 +51,13 @@ const AuthorityRadioContainer = ({
   }, []);
 
   const onChangeInitAuthMembers = () => {
-    setIsAll(false);
+    setIsPublic(false);
     openModal('newTopic');
     setAuthorizedMemberIds([]);
   };
 
-  const onChangeInitAuthMembersWithSetIsAll = () => {
-    setIsAll(true);
+  const onChangeInitAuthMembersWithSetIsPublic = () => {
+    setIsPublic(true);
     setAuthorizedMemberIds([]);
   };
 
@@ -114,7 +114,7 @@ const AuthorityRadioContainer = ({
             type="radio"
             id="permission-all"
             checked={isPublic}
-            onChange={onChangeInitAuthMembersWithSetIsAll}
+            onChange={onChangeInitAuthMembersWithSetIsPublic}
             tabIndex={5}
           />
           <Space size={1} />
@@ -242,7 +242,7 @@ const AuthorityRadioContainer = ({
               variant="secondary"
               onClick={() => {
                 closeModal('newTopic');
-                setIsAll(true);
+                setIsPublic(true);
                 setAuthorizedMemberIds([]);
               }}
             >

diff --git a/frontend/src/components/TopicInfo/UpdatedTopicInfo.tsx b/frontend/src/components/TopicInfo/UpdatedTopicInfo.tsx
@@ -143,7 +143,7 @@ const UpdatedTopicInfo = ({
         isPublic={isPublic}
         authorizedMemberIds={authorizedMemberIds}
         setIsPrivate={setIsPrivate}
-        setIsAll={setIsPublic}
+        setIsPublic={setIsPublic}
         setAuthorizedMemberIds={setAuthorizedMemberIds}
         permissionedMembers={topicAuthorInfo?.permissionedMembers}
       />

diff --git a/frontend/src/pages/NewTopic.tsx b/frontend/src/pages/NewTopic.tsx
@@ -86,7 +86,7 @@ const NewTopic = () => {
       description: formValues.description,
       pins: pulledPinIds ? pulledPinIds.split(',') : [],
       publicity: isPrivate ? 'PRIVATE' : 'PUBLIC',
-      permissionType: isAll && !isPrivate ? 'ALL_MEMBERS' : 'GROUP_ONLY',
+      permissionType: isPublic && !isPrivate ? 'ALL_MEMBERS' : 'GROUP_ONLY',
     };
 
     const data = JSON.stringify(objectData);
@@ -204,7 +204,7 @@ const NewTopic = () => {
           isPublic={isPublic}
           authorizedMemberIds={authorizedMemberIds}
           setIsPrivate={setIsPrivate}
-          setIsAll={setIsPublic}
+          setIsPublic={setIsPublic}
           setAuthorizedMemberIds={setAuthorizedMemberIds}
         />