[FE] Refactor/#513 지도 생성 및 핀 생성 페이지 지도 위치 조정 #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiwonh423
approved these changes
Sep 27, 2023
GC-Park
approved these changes
Sep 27, 2023
| if ($isAddPage) return 'column'; | ||
| if ($layoutWidth === '372px') return 'column-reverse'; |
Comment on lines
+232
to
+235
| if (!topicId && markers && markers.length > 0) { | ||
| removeMarkers(); | ||
| removeInfowindows(); | ||
| } |
There was a problem hiding this comment.
이 코드가 방금 말씀하신 핀 생성하기 갔을 때 핀 찍혀있는거 초기화 하는 부분이군요 ! 굿~!
Comment on lines
+144
to
+147
| if (!pulledPinIds && markers && markers.length > 0) { | ||
| removeMarkers(); | ||
| removeInfowindows(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 대상
📄 작업 내용
🙋🏻 주의 사항
스크린샷
📎 관련 이슈
close #513
레퍼런스