Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] 삭제된 토픽, 핀이 보이는 버그 해결 #558

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

yoondgu
Copy link
Collaborator

@yoondgu yoondgu commented Oct 6, 2023

작업 대상

개발서버 배포 시 코드리뷰 진행한 내용이기 때문에 2명 이상 approve되면 바로 merge하도록 하겠습니다!

📄 작업 내용

삭제된 토픽, 핀이 보이는 버그 해결 (soft delete)

🙋🏻 주의 사항

스크린샷

📎 관련 이슈

레퍼런스

cpot5620 and others added 2 commits October 2, 2023 19:40
* fix: Pin @where 적용으로 지연 로딩 시 soft delete 반영

* fix: Pin 삭제 시 pinCount 반영하도록 수정

- 검토할 TODO 다수 존재

* fix: Pin @where 적용에 따라 JPQL 원복

* refactor: Member update 메서드 형식 통일

* fix: Topic @where 적용으로 지연 로딩 시 soft delete 반영

* fix: PinImage @where 적용으로 지연 로딩 시 soft delete 반영

* refactor: 메서드명 수정

* refactor: AdminCommandService 의 불필요한 EntityManager 의존성 제거

* refactor: 누락된 삭제 로직 TODO 작성

* refactor: 개행 수정

* refactor: 개행 수정

* fix: 토픽 삭제 중복 로직이나 사용되지 않는 API 코드 @deprecated 처리

* fix: 토픽 삭제 시 연관 관계 지우지 않는 부분 수정

* fix: AuthMember 생성 시 정상 사용자만 조회하도록 filter 추가, 검증 추가

* test: AuthServiceTest 작성

* chore: /permissions/id API @deprecated 추가
@yoondgu yoondgu added bug Something isn't working BE 백엔드 관련 이슈 우선순위 : 상 labels Oct 6, 2023
@yoondgu yoondgu self-assigned this Oct 6, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Unit Test Results

  68 files    68 suites   23s ⏱️
302 tests 302 ✔️ 0 💤 0
311 runs  311 ✔️ 0 💤 0

Results for commit 9776f6e.

Copy link
Collaborator

@junpakPark junpakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 하셨습니다 👍👍

Copy link
Collaborator

@cpot5620 cpot5620 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@yoondgu yoondgu merged commit 4cf019b into main Oct 6, 2023
Copy link
Collaborator

@kpeel5839 kpeel5839 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 지금 봤네!

@junpakPark junpakPark deleted the develop-BE branch October 6, 2023 13:34
@yoondgu yoondgu restored the develop-BE branch October 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드 관련 이슈 bug Something isn't working 우선순위 : 상
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants