Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled autocorrect on Samsung device with Samsung keyboard on API 33+ #1063

Merged

Conversation

khaykov
Copy link
Member

@khaykov khaykov commented Oct 11, 2023

Fixes #1026

Autocorrect on Samsung have been broken for some time, which resulted in occasional text duplication.

This PR disables auto-correction on devices with Samsung with Android 13 that are using Samsung keyboard. We will still have suggestions and ability to manually commit them. I believe that this experience is better then what we have now.

Test

  1. Open the app using Samsung device with android 13 and Samsung keyboard.
  2. Type some text into the app.
  3. Confirm that nothing looks off - focus stays where it should be, image is present, styles are not being removed.
  4. Confirm that autocorrect is not working - type something like "I hav " (with the space at the end) and notice that hav is not changed into have.
  5. Switch to Gboard (or other keyboard).
  6. Confirm that autocorrect is working - type something like "I hav " (with the space at the end) and notice that hav IS changed into have.
  7. Change back to samsung keyboard and confirm that the autocorrect is still disabled.

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@khaykov khaykov marked this pull request as ready for review October 11, 2023 19:01
@nbradbury nbradbury self-assigned this Oct 12, 2023
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nbradbury nbradbury merged commit 1614ca1 into trunk Oct 12, 2023
2 checks passed
@nbradbury nbradbury deleted the issue/disabled-autocorrect-on-certain-samsung-devices branch October 12, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After space is deleted when typing new characters on Samsung android 13 words are added.
2 participants