Improved fix for IllegalArgumentException: Center point is not inside any of the rectangles #1094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #880 880
This is an improved fix for the crash when selecting empty editor with an end of buffer marker in it.
Original fix addressed case where you press on "Select All", but the problem is that some devices have their own option for selecting text in addition to "Select All". My One Plus device has a "Select" option that causes the crash as well. Problem with this, is that each manufacturer has a different ID for that button, and we can't catch them all. I added the logic for catching other select events into the
onSelectionChanged
.Test
If you have a device with an additional "Select" option in context menu.
aztec.visualEditor.fromHtml("<ol><li></li></ol>")
. We use list to be able to see the span.If you do not have a device with a "Select" option, you can still test the functionality by commenting out this part.
aztec.visualEditor.fromHtml("<h1></h1>")
.Make sure strings will be translated:
strings.xml
as a part of the integration PR.