Skip to content

Commit

Permalink
Remove unused reader styles
Browse files Browse the repository at this point in the history
  • Loading branch information
@RenanLukas
RenanLukas committed Jun 6, 2024
1 parent 5cd7e4a commit f933e21
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 110 deletions.
2 changes: 1 addition & 1 deletion WordPress/src/main/res/layout/reader_site_header_view.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
style="@style/ReaderImageView.Avatar.ExtraLarge"
android:background="@drawable/bg_oval_placeholder"
android:contentDescription="@null"
android:padding="@dimen/reader_site_header_avatar_padding_new"
android:padding="@dimen/reader_site_header_avatar_padding"
android:src="@drawable/bg_oval_placeholder_image_32dp"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent" />
Expand Down
11 changes: 1 addition & 10 deletions WordPress/src/main/res/values/dimens.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@
<dimen name="reader_card_gutters">0dp</dimen>
<dimen name="reader_card_elevation">0dp</dimen>
<dimen name="reader_card_elevation_new">0dp</dimen>
<dimen name="reader_site_header_avatar_margin_end">20dp</dimen>

<dimen name="reader_video_overlay_size">56dp</dimen>

Expand All @@ -141,10 +140,6 @@
<!-- padding inside the card (space between card border and card content) -->
<dimen name="reader_card_content_padding">16dp</dimen>

<!-- padding inside the tag header view -->
<dimen name="reader_tag_header_horizontal_padding">20dp</dimen>
<dimen name="reader_tag_header_vertical_padding">40dp</dimen>

<!-- reader follow unfollow comments dimensions -->
<dimen name="reader_follow_sheet_message_margin_top">20dp</dimen>
<dimen name="reader_follow_sheet_switch_margin_top">4dp</dimen>
Expand Down Expand Up @@ -232,11 +227,7 @@
<dimen name="reader_more_image_extra_padding">12dp</dimen>

<dimen name="reader_chip_radius">8dp</dimen>
<dimen name="reader_site_header_avatar_padding">2dp</dimen>
<dimen name="reader_site_header_avatar_padding_new">1dp</dimen>

<dimen name="reader_expandable_tags_view_chip_radius">4dp</dimen>
<dimen name="reader_expandable_tags_view_chip_height">24dp</dimen>
<dimen name="reader_site_header_avatar_padding">1dp</dimen>

<dimen name="reader_expandable_tags_view_chip_new_radius">5dp</dimen>
<dimen name="reader_expandable_tags_view_chip_new_border">1dp</dimen>
Expand Down
102 changes: 3 additions & 99 deletions WordPress/src/main/res/values/reader_styles.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,22 +47,7 @@
<item name="android:maxLines">1</item>
<item name="android:alpha">@dimen/material_emphasis_high_type</item>
</style>

<style name="ReaderTextView.Site.Description" parent="ReaderTextView">
<item name="android:textAlignment">viewStart</item>
<item name="android:textAppearance">?attr/textAppearanceBody2</item>
<item name="textColor">?attr/colorOnBackground</item>
<item name="android:ellipsize">end</item>
<item name="android:maxLines">2</item>
<item name="android:alpha">@dimen/material_emphasis_high_type</item>
</style>

<style name="ReaderTextView.Site.Header.Caption.Url">
<item name="android:textAlignment">viewStart</item>
<item name="android:ellipsize">end</item>
<item name="android:maxLines">1</item>
</style>


<style name="ReaderTextView.Post.Title" parent="ReaderTextView">
<item name="android:layout_width">match_parent</item>
<item name="android:layout_height">wrap_content</item>
Expand Down Expand Up @@ -94,26 +79,6 @@
<item name="android:ellipsize">end</item>
</style>

<style name="ReaderTextView.XPost.SubTitle" parent="ReaderTextView">
<item name="android:textAppearance">?attr/textAppearanceCaption</item>
<item name="android:alpha">@dimen/material_emphasis_high_type</item>
<item name="android:minHeight">@dimen/avatar_sz_extra_small</item>
<item name="android:gravity">center_vertical</item>
<item name="android:layout_marginStart">@dimen/margin_medium</item>
<item name="android:ellipsize">end</item>
<item name="android:maxLines">2</item>
<item name="android:fontFamily">serif</item>
</style>

<style name="ReaderTextView.RemovedPost.Title" parent="ReaderTextView">
<item name="android:ellipsize">marquee</item>
<item name="android:singleLine">true</item>
<item name="android:fontFamily">serif</item>
<item name="android:textAppearance">?attr/textAppearanceSubtitle1</item>
<item name="android:alpha">@dimen/material_emphasis_high_type</item>
<item name="android:gravity">center_vertical</item>
</style>

<style name="ReaderTextView.MetaHeader">
<item name="android:layout_width">match_parent</item>
<item name="android:layout_height">wrap_content</item>
Expand All @@ -139,17 +104,6 @@
<item name="android:gravity">center</item>
</style>

<style name="ReaderTextView.Card.Header" parent="ReaderTextView.Interests.Title">
<item name="android:layout_margin">@dimen/margin_extra_large</item>
<item name="android:textAppearance">?attr/textAppearanceHeadline6</item>
</style>

<style name="ReaderTextView.Interests.ListItem.Chip" parent="">
<item name="android:layout_width">0dp</item>
<item name="android:layout_height">wrap_content</item>
<item name="android:textAppearance">?attr/textAppearanceBody1</item>
</style>

<style name="ReaderTextView.Interests.Title" parent="ReaderTextView">
<item name="android:layout_width">0dp</item>
<item name="android:layout_height">wrap_content</item>
Expand Down Expand Up @@ -182,13 +136,6 @@
<item name="android:ellipsize">end</item>
</style>

<style name="ReaderTextView.Site.Header.Title" parent="ReaderTextView">
<item name="android:textAppearance">?attr/textAppearanceHeadline6</item>
<item name="textColor">?attr/colorOnSurface</item>
<item name="android:gravity">start</item>
<item name="android:fontFamily">serif</item>
</style>

<style name="ReaderTextView.Site.Header.NewTitle" parent="ReaderTextView">
<item name="android:textAppearance">@style/TextAppearance.Material3.HeadlineMedium</item>
<item name="android:textColor">?attr/colorOnSurface</item>
Expand All @@ -200,34 +147,6 @@
<item name="autoSizeMinTextSize">@dimen/text_sz_larger</item>
</style>

<style name="ReaderTextView.Site.Header.Caption" parent="ReaderTextView">
<item name="android:textAppearance">?attr/textAppearanceCaption</item>
<item name="textColor">?attr/colorOnSurface</item>
<item name="android:gravity">start</item>
<item name="android:alpha">@dimen/material_emphasis_high_type</item>
</style>

<style name="ReaderTextView.Site.Header.Body" parent="ReaderTextView">
<item name="android:textAppearance">?attr/textAppearanceBody2</item>
<item name="textColor">?attr/colorOnSurface</item>
<item name="android:gravity">start</item>
<item name="android:lineSpacingMultiplier">1.2</item>
<item name="android:ellipsize">end</item>
<item name="android:maxLines">3</item>
<item name="android:paddingStart">@dimen/margin_extra_large</item>
<item name="android:paddingEnd">@dimen/margin_extra_large</item>
<item name="android:paddingTop">@dimen/margin_medium</item>
<item name="android:paddingBottom">@dimen/margin_extra_large</item>
</style>

<style name="ReaderTextView.Tag.Header.Title" parent="ReaderTextView">
<item name="android:textAppearance">?attr/textAppearanceHeadline5</item>
<item name="textColor">?attr/textColor</item>
<item name="android:textAlignment">center</item>
<item name="android:gravity">center_vertical</item>
<item name="android:fontFamily">sans-serif-medium</item>
</style>

<style name="ReaderTextView.Tag.Header.NewTitle" parent="ReaderTextView.Site.Header.NewTitle"/>

<style name="Reader.TextView.Error" parent="Widget.MaterialComponents.TextView">
Expand Down Expand Up @@ -349,11 +268,6 @@
<item name="android:layout_height">@dimen/avatar_sz_small</item>
</style>

<style name="ReaderImageView.Avatar.ExtraSmall" parent="ReaderImageView">
<item name="android:layout_width">@dimen/avatar_sz_extra_small</item>
<item name="android:layout_height">@dimen/avatar_sz_extra_small</item>
</style>

<style name="ReaderImageView.Avatar.ExtraSmall.OvalSurfaceBackground" parent="ReaderImageView">
<item name="android:layout_width">@dimen/avatar_sz_extra_small_with_padding</item>
<item name="android:layout_height">@dimen/avatar_sz_extra_small_with_padding</item>
Expand Down Expand Up @@ -390,24 +304,14 @@

<!-- chips -->
<style name="ReaderChip" parent="@style/Widget.MaterialComponents.Chip.Filter">
<item name="android:textSize">@dimen/text_sz_large</item>
<item name="android:textAppearance">?attr/textAppearanceBody1</item>
<item name="android:lineSpacingMultiplier">1.5</item>
<item name="android:maxLines">1</item>
<item name="android:ellipsize">end</item>
<item name="checkedIconVisible">false</item>
<item name="chipCornerRadius">@dimen/reader_chip_radius</item>
</style>

<style name="ReaderChipNew" parent="@style/Widget.MaterialComponents.Chip.Filter">
<item name="android:textAppearance">@style/TextAppearance.Material3.BodyMedium</item>
<item name="android:maxLines">1</item>
<item name="android:ellipsize">end</item>
<item name="checkedIconVisible">false</item>
<item name="chipCornerRadius">@dimen/reader_chip_radius</item>
</style>

<style name="ReaderInterestFilterChip" parent="@style/ReaderChipNew">
<style name="ReaderInterestFilterChip" parent="@style/ReaderChip">
<item name="android:checkable">true</item>
<item name="chipMinHeight">@dimen/reader_interest_filter_chip_height</item>
<item name="chipStartPadding">@dimen/margin_large</item>
Expand All @@ -423,7 +327,7 @@
<item name="rippleColor">@color/reader_interest_filter_chip_ripple_selector</item>
</style>

<style name="ReaderExpandableTagsViewChip" parent="@style/ReaderChipNew">
<style name="ReaderExpandableTagsViewChip" parent="@style/ReaderChip">
<item name="android:checkable">false</item>
<item name="chipMinHeight">@dimen/reader_expandable_tags_view_chip_new_height</item>
<item name="chipStartPadding">@dimen/margin_extra_large</item>
Expand Down

0 comments on commit f933e21

Please sign in to comment.