[Nullability Annotations to Java Classes] Add Missing Nullability Annotations to All SDK Override Methods for Fragments

WordPress/src/main/java/org/wordpress/android/ui/ShareIntentReceiverFragment.java

@@ -9,6 +9,7 @@
 import android.widget.Button;
 import android.widget.TextView;
 
+import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import androidx.fragment.app.Fragment;
 import androidx.recyclerview.widget.LinearLayoutManager;
@@ -57,7 +58,7 @@ public static ShareIntentReceiverFragment newInstance(boolean sharingMediaFile,
     }
 
     @Override
-    public void onAttach(Context context) {
+    public void onAttach(@NonNull Context context) {
         super.onAttach(context);
         if (context instanceof ShareIntentFragmentListener) {
             mShareIntentFragmentListener = (ShareIntentFragmentListener) context;
@@ -76,7 +77,7 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
 
     @Nullable
     @Override
-    public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
+    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container,
                              @Nullable Bundle savedInstanceState) {
         ViewGroup layout = (ViewGroup) inflater.inflate(R.layout.share_intent_receiver_fragment, container, false);
         initButtonsContainer(layout);
@@ -95,14 +96,14 @@ public void onCreate(@Nullable Bundle savedInstanceState) {
         loadSavedState(savedInstanceState);
     }
 
-    private void loadSavedState(Bundle savedInstanceState) {
+    private void loadSavedState(@Nullable Bundle savedInstanceState) {
         if (savedInstanceState != null) {
             mLastUsedBlogLocalId = savedInstanceState.getInt(ARG_LAST_USED_BLOG_LOCAL_ID);
         }
     }
 
     @Override
-    public void onSaveInstanceState(Bundle outState) {
+    public void onSaveInstanceState(@NonNull Bundle outState) {
         super.onSaveInstanceState(outState);
         int selectedItemLocalId = mAdapter.getSelectedItemLocalId();
         if (selectedItemLocalId != -1) {
@@ -129,7 +130,7 @@ private void initShareActionMediaButton(final ViewGroup layout, boolean sharingM
     private void addShareActionListener(final Button button, final ShareAction shareAction) {
         button.setOnClickListener(new OnClickListener() {
             @Override
-            public void onClick(View v) {
+            public void onClick(@NonNull View v) {
                 mShareIntentFragmentListener.share(shareAction, mAdapter.getSelectedItemLocalId());
             }
         });

WordPress/src/main/java/org/wordpress/android/ui/accounts/login/LoginEpilogueFragment.java

@@ -154,7 +154,7 @@ protected void setupBottomButton(Button button) {
     }
 
     @Override
-    public void onCreate(Bundle savedInstanceState) {
+    public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
         mDoLoginUpdate = requireArguments().getBoolean(ARG_DO_LOGIN_UPDATE, false);
@@ -165,7 +165,7 @@ public void onCreate(Bundle savedInstanceState) {
     }
 
     @Override
-    public void onViewCreated(View view, @Nullable Bundle savedInstanceState) {
+    public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
         super.onViewCreated(view, savedInstanceState);
         initViewModel();
     }
@@ -301,7 +301,7 @@ public boolean onSiteLongClick(SiteRecord site) {
     }
 
     @Override
-    public void onAttach(Context context) {
+    public void onAttach(@NonNull Context context) {
         super.onAttach(context);
         if (context instanceof LoginEpilogueListener) {
             mLoginEpilogueListener = (LoginEpilogueListener) context;
@@ -370,15 +370,15 @@ private void bindFooterViewHolder(LoginFooterViewHolder holder, SiteList sites)
     }
 
     @Override
-    public void beforeTextChanged(CharSequence s, int start, int count, int after) {
+    public void beforeTextChanged(@NonNull CharSequence s, int start, int count, int after) {
     }
 
     @Override
-    public void onTextChanged(CharSequence s, int start, int before, int count) {
+    public void onTextChanged(@NonNull CharSequence s, int start, int before, int count) {
     }
 
     @Override
-    public void afterTextChanged(Editable s) {
+    public void afterTextChanged(@NonNull Editable s) {
     }
 
     @Override

WordPress/src/main/java/org/wordpress/android/ui/accounts/signup/SignupEpilogueFragment.java

@@ -188,14 +188,14 @@ protected void setupContent(ViewGroup rootView) {
         headerAvatarLayout.setEnabled(mIsEmailSignup);
         headerAvatarLayout.setOnClickListener(new View.OnClickListener() {
             @Override
-            public void onClick(View view) {
+            public void onClick(@NonNull View v) {
                 mUnifiedLoginTracker.trackClick(Click.SELECT_AVATAR);
                 mMediaPickerLauncher.showGravatarPicker(SignupEpilogueFragment.this);
             }
         });
         headerAvatarLayout.setOnLongClickListener(new View.OnLongClickListener() {
             @Override
-            public boolean onLongClick(View view) {
+            public boolean onLongClick(@NonNull View v) {
                 ToastUtils.showToast(getActivity(), getString(R.string.content_description_add_avatar),
                         ToastUtils.Duration.SHORT);
                 return true;
@@ -214,15 +214,15 @@ public boolean onLongClick(View view) {
         mEditTextDisplayName.setText(mDisplayName);
         mEditTextDisplayName.addTextChangedListener(new TextWatcher() {
             @Override
-            public void beforeTextChanged(CharSequence s, int start, int count, int after) {
+            public void beforeTextChanged(@NonNull CharSequence s, int start, int count, int after) {
             }
 
             @Override
-            public void onTextChanged(CharSequence s, int start, int before, int count) {
+            public void onTextChanged(@NonNull CharSequence s, int start, int before, int count) {
             }
 
             @Override
-            public void afterTextChanged(Editable s) {
+            public void afterTextChanged(@NonNull Editable s) {
                 mDisplayName = s.toString();
                 mHeaderDisplayName.setText(mDisplayName);
             }
@@ -232,22 +232,22 @@ public void afterTextChanged(Editable s) {
         mEditTextUsername.setText(mUsername);
         mEditTextUsername.setOnClickListener(new View.OnClickListener() {
             @Override
-            public void onClick(View view) {
+            public void onClick(@NonNull View v) {
                 mUnifiedLoginTracker.trackClick(Click.EDIT_USERNAME);
                 launchDialog();
             }
         });
         mEditTextUsername.setOnFocusChangeListener(new View.OnFocusChangeListener() {
             @Override
-            public void onFocusChange(View view, boolean hasFocus) {
+            public void onFocusChange(@NonNull View v, boolean hasFocus) {
                 if (hasFocus) {
                     launchDialog();
                 }
             }
         });
         mEditTextUsername.setOnKeyListener(new View.OnKeyListener() {
             @Override
-            public boolean onKey(View view, int keyCode, KeyEvent event) {
+            public boolean onKey(@NonNull View v, int keyCode, @NonNull KeyEvent event) {
                 // Consume keyboard events except for Enter (i.e. click/tap) and Tab (i.e. focus/navigation).
                 // The onKey method returns true if the listener has consumed the event and false otherwise
                 // allowing hardware keyboard users to tap and navigate, but not input text as expected.
@@ -269,7 +269,8 @@ public boolean onKey(View view, int keyCode, KeyEvent event) {
                 (OnScrollChangeListener) (v, scrollX, scrollY, oldScrollX, oldScrollY) -> showBottomShadowIfNeeded());
         // We must use onGlobalLayout here otherwise canScrollVertically will always return false
         mScrollView.getViewTreeObserver().addOnGlobalLayoutListener(new OnGlobalLayoutListener() {
-            @Override public void onGlobalLayout() {
+            @Override
+            public void onGlobalLayout() {
                 mScrollView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
                 showBottomShadowIfNeeded();
             }
@@ -289,15 +290,15 @@ private void showBottomShadowIfNeeded() {
     protected void setupBottomButton(Button button) {
         button.setOnClickListener(new View.OnClickListener() {
             @Override
-            public void onClick(View view) {
+            public void onClick(@NonNull View v) {
                 mUnifiedLoginTracker.trackClick(Click.CONTINUE);
                 updateAccountOrContinue();
             }
         });
     }
 
     @Override
-    public void onCreate(Bundle savedInstanceState) {
+    public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         ((WordPress) getActivity().getApplication()).component().inject(this);
         mDispatcher.dispatch(AccountActionBuilder.newFetchAccountAction());
@@ -364,7 +365,7 @@ public void onActivityCreated(@Nullable Bundle savedInstanceState) {
 
     @Override
     @SuppressWarnings("deprecation")
-    public void onActivityResult(int requestCode, int resultCode, Intent data) {
+    public void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
         super.onActivityResult(requestCode, resultCode, data);
 
         if (isAdded()) {
@@ -434,7 +435,7 @@ public void doNext(Uri uri) {
     }
 
     @Override
-    public void onAttach(Context context) {
+    public void onAttach(@NonNull Context context) {
         super.onAttach(context);
 
         if (context instanceof SignupEpilogueListener) {
@@ -468,7 +469,7 @@ public void onShown() {
     }
 
     @Override
-    public void onSaveInstanceState(Bundle outState) {
+    public void onSaveInstanceState(@NonNull Bundle outState) {
         super.onSaveInstanceState(outState);
         outState.putString(KEY_PHOTO_URL, mPhotoUrl);
         outState.putString(KEY_DISPLAY_NAME, mDisplayName);
@@ -482,15 +483,15 @@ public void onSaveInstanceState(Bundle outState) {
     }
 
     @Override
-    public void beforeTextChanged(CharSequence s, int start, int count, int after) {
+    public void beforeTextChanged(@NonNull CharSequence s, int start, int count, int after) {
     }
 
     @Override
-    public void onTextChanged(CharSequence s, int start, int before, int count) {
+    public void onTextChanged(@NonNull CharSequence s, int start, int before, int count) {
     }
 
     @Override
-    public void afterTextChanged(Editable s) {
+    public void afterTextChanged(@NonNull Editable s) {
     }
 
     @Override
@@ -665,7 +666,7 @@ private void populateViews() {
     protected void showErrorDialog(String message) {
         DialogInterface.OnClickListener dialogListener = new DialogInterface.OnClickListener() {
             @Override
-            public void onClick(DialogInterface dialog, int which) {
+            public void onClick(@Nullable DialogInterface dialog, int which) {
                 switch (which) {
                     case DialogInterface.BUTTON_NEGATIVE:
                         undoChanges();

WordPress/src/main/java/org/wordpress/android/ui/comments/CommentDetailFragment.java

@@ -224,7 +224,7 @@ public static CommentDetailFragment newInstance(final String noteId, final Strin
     }
 
     @Override
-    public void onCreate(Bundle savedInstanceState) {
+    public void onCreate(@Nullable Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
         ((WordPress) getActivity().getApplication()).component().inject(this);
 
@@ -277,9 +277,11 @@ public void onDestroy() {
     }
 
     // touching the file resulted in the MethodLength, it's suppressed until we get time to refactor this method
-    @SuppressWarnings("checkstyle:MethodLength")
+    @Nullable
     @Override
-    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+    @SuppressWarnings("checkstyle:MethodLength")
+    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container,
+                             @Nullable Bundle savedInstanceState) {
         final View view = inflater.inflate(R.layout.comment_detail_fragment, container, false);
 
         mMediumOpacity = ResourcesCompat.getFloat(
@@ -337,15 +339,15 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
         mEditReply.initializeWithPrefix('@');
         mEditReply.addTextChangedListener(new TextWatcher() {
             @Override
-            public void beforeTextChanged(CharSequence s, int start, int count, int after) {
+            public void beforeTextChanged(@NonNull CharSequence s, int start, int count, int after) {
             }
 
             @Override
-            public void onTextChanged(CharSequence s, int start, int before, int count) {
+            public void onTextChanged(@NonNull CharSequence s, int start, int before, int count) {
             }
 
             @Override
-            public void afterTextChanged(Editable s) {
+            public void afterTextChanged(@NonNull Editable s) {
                 mSubmitReplyBtn.setEnabled(!TextUtils.isEmpty(s.toString().trim()));
             }
         });
@@ -641,7 +643,7 @@ public void onPause() {
 
     @Override
     @SuppressWarnings("deprecation")
-    public void onActivityResult(int requestCode, int resultCode, Intent data) {
+    public void onActivityResult(int requestCode, int resultCode, @Nullable Intent data) {
         super.onActivityResult(requestCode, resultCode, data);
         if (requestCode == INTENT_COMMENT_EDITOR && resultCode == Activity.RESULT_OK) {
             reloadComment();
@@ -1639,8 +1641,9 @@ private void showSnackBar(String message) {
         }
     }
 
+    @Nullable
     @Override
-    @Nullable public View getScrollableViewForUniqueIdProvision() {
+    public View getScrollableViewForUniqueIdProvision() {
         return mNestedScrollView;
     }
 }

WordPress/src/main/java/org/wordpress/android/ui/history/HistoryDetailContainerFragment.java

@@ -100,8 +100,10 @@ public static HistoryDetailContainerFragment newInstance(final Revision revision
         return fragment;
     }
 
+    @Nullable
     @Override
-    public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
+    public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container,
+                             @Nullable Bundle savedInstanceState) {
         ViewGroup rootView = (ViewGroup) inflater.inflate(R.layout.history_detail_container_fragment, container, false);
 
         mIsFragmentRecreated = savedInstanceState != null;
@@ -227,20 +229,20 @@ public void onSaveInstanceState(@NonNull Bundle outState) {
     }
 
     @Override
-    public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
+    public void onCreateOptionsMenu(@NonNull Menu menu, @NonNull MenuInflater inflater) {
         super.onCreateOptionsMenu(menu, inflater);
         inflater.inflate(R.menu.history_detail, menu);
     }
 
     @Override
-    public void onPrepareOptionsMenu(Menu menu) {
+    public void onPrepareOptionsMenu(@NonNull Menu menu) {
         super.onPrepareOptionsMenu(menu);
         MenuItem viewMode = menu.findItem(R.id.history_toggle_view);
         viewMode.setTitle(isInVisualPreview() ? R.string.history_preview_html : R.string.history_preview_visual);
     }
 
     @Override
-    public boolean onOptionsItemSelected(MenuItem item) {
+    public boolean onOptionsItemSelected(@NonNull MenuItem item) {
         if (item.getItemId() == R.id.history_load) {
             Intent intent = new Intent();
             intent.putExtra(KEY_REVISION, mRevision);
@@ -353,6 +355,7 @@ private class HistoryDetailFragmentAdapter extends FragmentStatePagerAdapter {
             mRevisions = (ArrayList<Revision>) revisions.clone();
         }
 
+        @NonNull
         @Override
         public Fragment getItem(int position) {
             return HistoryDetailFragment.Companion.newInstance(mRevisions.get(position));
@@ -364,14 +367,15 @@ public int getCount() {
         }
 
         @Override
-        public void restoreState(Parcelable state, ClassLoader loader) {
+        public void restoreState(@Nullable Parcelable state, @Nullable ClassLoader loader) {
             try {
                 super.restoreState(state, loader);
             } catch (IllegalStateException exception) {
                 AppLog.e(T.EDITOR, exception);
             }
         }
 
+        @Nullable
         @Override
         public Parcelable saveState() {
             Bundle bundle = (Bundle) super.saveState();