-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address NullPointerException
crash in AztecHeadingSpan
#19724
Address NullPointerException
crash in AztecHeadingSpan
#19724
Conversation
NullPointerException
crash in AztecHeadingSpan
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved via wordpress-mobile/AztecEditor-Android#1071 (review).
NOTE: If we plan to incorporate this fix in the ongoing beta version 23.8
, we should consider pointing this PR to the branch release/23.8
.
This comment was marked as outdated.
This comment was marked as outdated.
Found 1 violations: The PR caused the following dependency changes: \--- project :libs:editor
- +--- org.wordpress:aztec:{strictly v1.8.0} -> v1.8.0
+ +--- org.wordpress:aztec:{strictly v1.9.0} -> v1.9.0
- +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.8.0} -> v1.8.0
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v1.8.0 (*)
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v1.9.0} -> v1.9.0
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v1.9.0 (*)
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- org.wordpress.aztec:wordpress-comments:{strictly v1.8.0} -> v1.8.0
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v1.8.0 (*)
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+ +--- org.wordpress.aztec:wordpress-comments:{strictly v1.9.0} -> v1.9.0
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v1.9.0 (*)
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
\--- org.wordpress-mobile.gutenberg-mobile:react-native-gutenberg-bridge:v1.109.1
\--- org.wordpress-mobile.gutenberg-mobile:react-native-aztec:v1.109.1
- +--- org.wordpress:aztec:v1.8.0 (*)
+ +--- org.wordpress:aztec:v1.8.0 -> v1.9.0 (*)
- +--- org.wordpress.aztec:wordpress-shortcodes:v1.8.0 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:v1.8.0 -> v1.9.0 (*)
- +--- org.wordpress.aztec:wordpress-comments:v1.8.0 (*)
+ +--- org.wordpress.aztec:wordpress-comments:v1.8.0 -> v1.9.0 (*)
\--- org.wordpress.aztec:glide-loader:v1.8.0
- \--- org.wordpress:aztec:v1.8.0 (*)
+ \--- org.wordpress:aztec:v1.8.0 -> v1.9.0 (*)
Please review and act accordingly
|
6ec7ac4
to
f0220e1
Compare
f0220e1
to
e43e8d9
Compare
Generated by 🚫 dangerJS |
Fixes #18657
Related PRs
Gutenberg
: [RNMobile] AddressNullPointerException
crash inAztecHeadingSpan
WordPress/gutenberg#56757Gutenberg Mobile
: [RNMobile] AddressNullPointerException
crash inAztecHeadingSpan
gutenberg-mobile#6435Aztec Android
: AddressNullPointerException
crash inAztecHeadingSpan
AztecEditor-Android#1071To Test
Regression Notes
Potential unintended areas of impact
chooseHeight
override. As described here, that function defines the height for a given element. As such, changes to that override may impact how heights are calculated for heading blocks.What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.