-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Glide to 4.16.0
#20145
Bump Glide to 4.16.0
#20145
Conversation
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:editor
| \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.112.0
| +--- org.wordpress.react-native-libraries.v4:react-native-fast-image:8.5.11
-| | +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
-| | | +--- com.github.bumptech.glide:gifdecoder:4.15.1
-| | | | \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-| | | +--- com.github.bumptech.glide:disklrucache:4.15.1
-| | | +--- com.github.bumptech.glide:annotations:4.15.1
-| | | +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-| | | +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-| | | +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
-| | | \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+| | +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
+| | | +--- com.github.bumptech.glide:gifdecoder:4.16.0
+| | | | \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
+| | | +--- com.github.bumptech.glide:disklrucache:4.16.0
+| | | +--- com.github.bumptech.glide:annotations:4.16.0
+| | | +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+| | | +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+| | | +--- androidx.exifinterface:exifinterface:1.3.6 (*)
+| | | \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
| | \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-| | \--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
+| | \--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 (*)
| \--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.112.0
| \--- org.wordpress.aztec:glide-loader:v1.9.0
-| \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+| \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
+--- com.automattic:stories:2.4.0
-| +--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+| +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
| +--- jp.wasabeef:glide-transformations:4.3.0
-| | \--- com.github.bumptech.glide:glide:4.11.0 -> 4.15.1 (*)
+| | \--- com.github.bumptech.glide:glide:4.11.0 -> 4.16.0 (*)
| \--- com.automattic.stories:photoeditor:2.4.0
-| +--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+| +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
| \--- com.automattic.stories:mp4compose:2.4.0
-| \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+| \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-+--- com.github.bumptech.glide:glide:4.15.1 (*)
++--- com.github.bumptech.glide:glide:4.16.0 (*)
-\--- com.github.bumptech.glide:volley-integration:4.15.1
- +--- com.github.bumptech.glide:glide:4.15.1 (*)
- +--- com.android.volley:volley:1.2.0 -> 1.2.1
- \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+\--- com.github.bumptech.glide:volley-integration:4.16.0
+ +--- com.github.bumptech.glide:glide:4.16.0 (*)
+ +--- com.android.volley:volley:1.2.0 -> 1.2.1
+ \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## trunk #20145 +/- ##
==========================================
+ Coverage 40.17% 40.22% +0.04%
==========================================
Files 1469 1469
Lines 67634 67553 -81
Branches 11202 11182 -20
==========================================
- Hits 27174 27173 -1
+ Misses 37968 37891 -77
+ Partials 2492 2489 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚬 tested the app and haven't found any defects. Thanks for bumping Glide! 💯
Description
It required some further adjustments to not rely on generated code:
See details in the documentation.
To test
Please some test the app focusing on images.