Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Glide to 4.16.0 #20145

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Bump Glide to 4.16.0 #20145

merged 2 commits into from
Feb 16, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 8, 2024

Description

It required some further adjustments to not rely on generated code:

The generated API is deprecated as of Glide 4.14.0. Glide’s annotation processors will continue to be used for configuration.

See details in the documentation.

To test

Please some test the app focusing on images.

@wzieba wzieba added Tooling Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Feb 8, 2024
@wzieba wzieba added this to the 24.3 milestone Feb 8, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 8, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.3. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:editor
 |    \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.112.0
 |         +--- org.wordpress.react-native-libraries.v4:react-native-fast-image:8.5.11
-|         |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1
-|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.15.1
-|         |    |    |    \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-|         |    |    +--- com.github.bumptech.glide:disklrucache:4.15.1
-|         |    |    +--- com.github.bumptech.glide:annotations:4.15.1
-|         |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
-|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-|         |    |    +--- androidx.exifinterface:exifinterface:1.3.3 -> 1.3.6 (*)
-|         |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
+|         |    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0
+|         |    |    +--- com.github.bumptech.glide:gifdecoder:4.16.0
+|         |    |    |    \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)
+|         |    |    +--- com.github.bumptech.glide:disklrucache:4.16.0
+|         |    |    +--- com.github.bumptech.glide:annotations:4.16.0
+|         |    |    +--- androidx.fragment:fragment:1.3.6 -> 1.6.2 (*)
+|         |    |    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+|         |    |    +--- androidx.exifinterface:exifinterface:1.3.6 (*)
+|         |    |    \--- androidx.tracing:tracing:1.0.0 -> 1.1.0 (*)
 |         |    \--- com.github.bumptech.glide:okhttp3-integration:4.12.0
-|         |         \--- com.github.bumptech.glide:glide:4.12.0 -> 4.15.1 (*)
+|         |         \--- com.github.bumptech.glide:glide:4.12.0 -> 4.16.0 (*)
 |         \--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.112.0
 |              \--- org.wordpress.aztec:glide-loader:v1.9.0
-|                   \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+|                   \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
 +--- com.automattic:stories:2.4.0
-|    +--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+|    +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
 |    +--- jp.wasabeef:glide-transformations:4.3.0
-|    |    \--- com.github.bumptech.glide:glide:4.11.0 -> 4.15.1 (*)
+|    |    \--- com.github.bumptech.glide:glide:4.11.0 -> 4.16.0 (*)
 |    \--- com.automattic.stories:photoeditor:2.4.0
-|         +--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+|         +--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
 |         \--- com.automattic.stories:mp4compose:2.4.0
-|              \--- com.github.bumptech.glide:glide:4.10.0 -> 4.15.1 (*)
+|              \--- com.github.bumptech.glide:glide:4.10.0 -> 4.16.0 (*)
-+--- com.github.bumptech.glide:glide:4.15.1 (*)
++--- com.github.bumptech.glide:glide:4.16.0 (*)
-\--- com.github.bumptech.glide:volley-integration:4.15.1
-     +--- com.github.bumptech.glide:glide:4.15.1 (*)
-     +--- com.android.volley:volley:1.2.0 -> 1.2.1
-     \--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+\--- com.github.bumptech.glide:volley-integration:4.16.0
+     +--- com.github.bumptech.glide:glide:4.16.0 (*)
+     +--- com.android.volley:volley:1.2.0 -> 1.2.1
+     \--- androidx.annotation:annotation:1.5.0 -> 1.6.0 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 8, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20145-c6fd6c0
Commitc6fd6c0
Direct Downloadjetpack-prototype-build-pr20145-c6fd6c0.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 8, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20145-c6fd6c0
Commitc6fd6c0
Direct Downloadwordpress-prototype-build-pr20145-c6fd6c0.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (2741f03) 40.17% compared to head (2522515) 40.22%.
Report is 3 commits behind head on trunk.

❗ Current head 2522515 differs from pull request most recent head c6fd6c0. Consider uploading reports for the commit c6fd6c0 to get more accurate results

Files Patch % Lines
...a/org/wordpress/android/util/image/ImageManager.kt 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20145      +/-   ##
==========================================
+ Coverage   40.17%   40.22%   +0.04%     
==========================================
  Files        1469     1469              
  Lines       67634    67553      -81     
  Branches    11202    11182      -20     
==========================================
- Hits        27174    27173       -1     
+ Misses      37968    37891      -77     
+ Partials     2492     2489       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wzieba wzieba marked this pull request as ready for review February 8, 2024 13:30
@wzieba wzieba requested review from a team and justtwago and removed request for a team February 8, 2024 13:30
Copy link
Contributor

@justtwago justtwago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚬 tested the app and haven't found any defects. Thanks for bumping Glide! 💯

Base automatically changed from bump_dagger_to_2.50 to trunk February 16, 2024 16:59
@wzieba wzieba removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Feb 16, 2024
@wzieba wzieba enabled auto-merge February 16, 2024 17:05
@wzieba wzieba merged commit 9cb8b62 into trunk Feb 16, 2024
19 of 20 checks passed
@wzieba wzieba deleted the bumo_glide_to_4.16.0 branch February 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants