The inline action of Like Comment

[jarvislin]

Part of #20024

This is the feature for liking a comment from the inline action.
This PR contains:

1. The implementation of the Like Comment inline action.
2. Refactor the codebase.

---

To Test:

1. Open the Jetpack app and switch to the notifications tab.
2. Scroll the top tab to COMMENTS and click it.
3. Click on the star icon in the notification item.
4. The Like status should be updated.
5. Done, thank you!

Light	Dark	RTL

---

Regression Notes

1. Potential unintended areas of impact

   • Notification tab

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual

3. What automated tests I added (or what prevented me from doing so)

   • None, sadly we still haven't made our code testable yet.

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20187-2b40d4c
	Commit	2b40d4c
	Direct Download	jetpack-prototype-build-pr20187-2b40d4c.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20187-2b40d4c
	Commit	2b40d4c
	Direct Download	wordpress-prototype-build-pr20187-2b40d4c.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (a9a0972) 40.15% compared to head (2b40d4c) 40.14%.

Files	Patch %	Lines
.../ui/notifications/NotificationsListFragmentPage.kt	0.00%	20 Missing ⚠️
...oid/ui/notifications/NotificationsListViewModel.kt	0.00%	18 Missing ⚠️
...c/main/java/org/wordpress/android/models/Note.java	0.00%	6 Missing ⚠️
...ava/org/wordpress/android/models/NoteExtensions.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                          @@
##           feature/notifications_refresh_p1   #20187      +/-   ##
====================================================================
- Coverage                             40.15%   40.14%   -0.01%     
====================================================================
  Files                                  1469     1469              
  Lines                                 67683    67697      +14     
  Branches                              11211    11210       -1     
====================================================================
  Hits                                  27179    27179              
- Misses                                38010    38024      +14     
  Partials                               2494     2494              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[jarvislin]

Thank you, @antonis Nice catch! I found that not only the gray color, but also the green color are different in light/dark mode.
I think it'd better if we can tint the color by icon types.

[antonis]

We could add a background dispatcher and use it in the "like coroutine" to avoid blocking the UI when updating the like status.
@Named(BG_THREAD) val bgDispatcher: CoroutineDispatcher

[jarvislin]

I'm gonna replace @Named(UI_THREAD) mainDispatcher: CoroutineDispatcher with @Named(BG_THREAD) val bgDispatcher: CoroutineDispatcher to see if the blocking issue in main thread can be resolved.

But I guess the root cause is not the about the dispatcher, it should throw NetworkOnMainThreadException if I run on the wrong thread.

I noticed that UI refreshes many times because of the event bus, I'd like to remove redundant events after #20024 is done.

[antonis]

Makes sense @jarvislin 👍

I noticed that UI refreshes many times because of the event bus, I'd like to remove redundant events after #20024 is done.

Sounds good. We can merge this PR and tackle this later.

[jarvislin]

Hmmm the main thread is blocking even I don't click on the action icon. So there should be a different root cause.

[antonis]

Great work @jarvislin 👍
I've tested the implementation on a Pixel 5/Android 14 and it worked as described in most cases for me. The code also looks good.
I've added a few comments inline with suggestions.

[antonis]

Thank you for the changes @jarvislin 🙇
All look good to me 🎉
We can iterate on the UI update issue later #20187 (comment)