-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stats analytics #20194
Update stats analytics #20194
Conversation
stats_insights_accessed was being tracked for always even when the insights tab was not selected. This fixes it and track the correct event.
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
02885cc
to
fdd2968
Compare
a22b094
to
02869c6
Compare
It is still showing...backward, and forward, instead of previous_date, and next_date. Test instructions also differ from what is stated in Description about renaming. 🔵 Tracked: stats_date_tapped_backward, Properties: {"period":"days"} |
Actually, the description is wrong implementation d4231a1 is correct! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for noticing. I have corrected the description. |
Fixes #20176
This updates analytics events related to the stats screen.
stats_insights_accessed
stats_period_accessed
granularity
andperiod
properties with the same value. Now it will include only "period".stats_previous_date_tapped
stats_previous_date_tapped
renamed tostats_date_tapped_backward
to match with iOS. Before it was sending null period, it has been fixed.stats_next_date_tapped
stats_next_date_tapped
renamed tostats_date_tapped_forward
to match with iOS. Before it was sending null period, it has been fixed.tap_source
property that has been added tostats_accesed
eventquick_actions
row
today_stats_card
notification
link
shortcut
activity_log
jetpack_connection
widget
To Test:
Test these for both disabled and enabled
stats_traffic_tab
flag. The flag can be set from "Me → Debug Settings".stats_insights_accessed
🔵 Tracked: stats_insights_accessed
is logged.🔵 Tracked: stats_insights_accessed
is logged again.stats_period_accessed
stats_traffic_tab
is disabled.🔵 Tracked: stats_period_accessed, Properties: {"period":"days"}
is logged.stats_traffic_tab
flag.🔵 Tracked: stats_period_accessed, Properties: {"period":"days"}
is logged.stats_previous_date_tapped
,stats_next_date_tapped
🔵 Tracked: stats_date_tapped_backward, Properties: {"period":"days"}
is logged with the proper period.🔵 Tracked: stats_date_tapped_forward, Properties: {"period":"days"}
is logged with the proper period.11. Disable the feature flag.
quick_actions
🔵 Tracked: stats_accessed, Properties: {"tap_source":"quick_actions",...}
is logged.row
🔵 Tracked: stats_accessed, Properties: {"tap_source":"row",...}
is logged.today_stats_card
🔵 Tracked: stats_accessed, Properties: {"tap_source":"today_stats_card",...}
is logged.notification
You need to use debug build to test this or wait Monday for weekly roundup notification.
🔵 Tracked: stats_accessed, Properties: {"tap_source":"notification",...}
is logged.link
If you know an easier way to test a deeplink, you can use it.
jetpack://stats
link.🔵 Tracked: stats_accessed, Properties: {"tap_source":"link",...}
is logged.shortcut
🔵 Tracked: stats_accessed, Properties: {"tap_source":"shortcut",...}
is logged.jetpack_connection
🔵 Tracked: stats_accessed, Properties: {"tap_source":"jetpack_connection",...}
is logged.activity_log
I couldn't find a way to test this. Please let me know if you can test it. I'm also pretty sure this PR will track the
activity_log
property properly.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist: