Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable crash logging (Sentry) debug logs also on debug #20198

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Feb 16, 2024

Sentry started to log too much after the bump to 6.32.0

See internal conversation: p1707817029678899-slack-C04TBSWP09M


To Test:

Run the app and see if the logs are not flooded with logs from Sentry tag


Regression Notes

  1. Potential unintended areas of impact

    • TODO
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • TODO
  3. What automated tests I added (or what prevented me from doing so)

    • TODO

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Sentry started to log too much after the bump to 6.32.0
@wzieba wzieba added the Tooling label Feb 16, 2024
@wzieba wzieba added this to the 24.3 milestone Feb 16, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Feb 16, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.3. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run the app and see if the logs are not flooded with logs from Sentry tag

This worked for me and I don't expect any side effects given that it was enabled only in debug builds.

Thank you for tackling this @wzieba 🙇

@wzieba wzieba marked this pull request as ready for review February 16, 2024 11:34
@wzieba wzieba enabled auto-merge February 16, 2024 11:34
@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20198-9fbd7bd
Commit9fbd7bd
Direct Downloadwordpress-prototype-build-pr20198-9fbd7bd.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20198-9fbd7bd
Commit9fbd7bd
Direct Downloadjetpack-prototype-build-pr20198-9fbd7bd.apk
Note: Google Login is not supported on these builds.

@wzieba wzieba merged commit adfde43 into trunk Feb 16, 2024
21 of 22 checks passed
@wzieba wzieba deleted the disable_crashlogging_logs_in_debug branch February 16, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants