[Tags IA] Fetch posts for multiple tags #20684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
April 10, 2024 16:32
This breaks the top bar filter behavior of the tags feed for now, since that requires the SubFilterViewModel to be properly initialized and communicate with the TopBar (via ReaderViewModel), which happens ONLY inside the ReaderPostListFragment for now.
Generated by 🚫 Danger |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20684-59ba75c | |
| Commit | 59ba75c | |
| Direct Download | wordpress-prototype-build-pr20684-59ba75c.apk |
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20684-59ba75c | |
| Commit | 59ba75c | |
| Direct Download | jetpack-prototype-build-pr20684-59ba75c.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/tags-ia #20684 +/- ##
===================================================
+ Coverage 40.33% 40.39% +0.06%
===================================================
Files 1474 1479 +5
Lines 67878 67950 +72
Branches 11225 11232 +7
===================================================
+ Hits 27377 27451 +74
+ Misses 38034 38024 -10
- Partials 2467 2475 +8 ☔ View full report in Codecov by Sentry. |
added 5 commits
April 22, 2024 12:16
RenanLukas
reviewed
Apr 24, 2024
There was a problem hiding this comment.
Thanks for the PR and all the nice improvements in the Reader logic, @thomashorta ! 💯
I've left a few comments (mostly nitpicks) and before approving I just wanted to better understand how the ReaderPostLocalSource class works. We can quickly chat when you're available.
WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
Outdated
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/ReaderTagsFeedFragment.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/repository/ReaderPostRepository.kt
Show resolved
Hide resolved
WordPress/src/main/java/org/wordpress/android/ui/reader/services/post/ReaderPostLogicFactory.kt
Outdated
Show resolved
Hide resolved
...ss/src/test/java/org/wordpress/android/ui/reader/services/post/ReaderPostLogicFactoryTest.kt
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20588
Move shared fetching logic to Repository and create ViewModel to use Repository to fetch posts for tags directly.
To Test:
reader_tags_feedfeature flag in Debug SettingsTagsfeedRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
N/A, the UI in this PR is completely throwaway and only there to easily test these changes.