Code

Notifications Refresh (Phase 2)#20697

Code

Closed

antonis wants to merge 153 commits intotrunkwordpress-mobile/WordPress-Android:trunkfrom feature/notifications_refresh_p2wordpress-mobile/WordPress-Android:feature/notifications_refresh_p2Copy head branch name to clipboard

+3,832-3,639

Commits

Commits on Apr 22, 2024

• Replace tab with a popup window

  

  Jarvis Lin

  committed
  c6b62b7

Commits on Apr 23, 2024

• Update the tab position

  

  Jarvis Lin

  committed
  345a6ef

• Update title when switch to different tab

  

  Jarvis Lin

  committed
  67f372f

• Disable swiping for the viewpager

  

  Jarvis Lin

  committed
  7e4143e

• Extract dimens values

  

  Jarvis Lin

  committed
  c6d3c0e

• Update the UI of header

  

  Jarvis Lin

  committed
  a1fe1f5

• Merge pull request #20693 from wordpress-mobile/issue/replace-the-tabs-with-a-dropdown-menu

  Show description for d4933db
  

  Antonis Lilis

  authored
  d4933db

• Extract dimens for the UI of header

  

  Jarvis Lin

  committed
  8d8ee41

Commits on Apr 24, 2024

• Merge branch 'feature/notifications_refresh_p2' into issue/Likes-Details-Header

  Show description for be7c455
  

  Jarvis Lin

  committed
  be7c455

• Remove useless code

  

  Jarvis Lin

  committed
  0cf7157

• Update the UI of list item

  

  Jarvis Lin

  committed
  92bd9e0

• Update the item attrs

  

  Jarvis Lin

  committed
  e6fc53c

• Merge branch 'issue/Likes-Details-List' into issue/Likes-Details-Header

  Show description for 13dc9cf
  

  Jarvis Lin

  committed
  13dc9cf

• Handle the CTA of Share a post

  

  Jarvis Lin

  committed
  2156320

• Handle the click for the Share CTA

  

  Jarvis Lin

  committed
  972847d

• Extract the string of button

  

  Jarvis Lin

  committed
  ef2723d

• Fix a lint issue

  

  Jarvis Lin

  committed
  cbdf847

• Extract the background color for light/dark themes

  

  Jarvis Lin

  committed
  a127468

• Merge pull request #20700 from wordpress-mobile/issue/Likes-Details-Header

  Show description for 28557c1
  jarvislin

  authored
  28557c1

• Merge branch 'feature/notifications_refresh_p2' into issue/Likes-Details-Share

  

  Jarvis Lin

  committed
  60b4e5a

• Extract a color

  

  Jarvis Lin

  committed
  d561f91

• Fix a unit test

  

  Jarvis Lin

  committed
  53819d1

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  6ec8b39

• Merge pull request #20709 from wordpress-mobile/issue/Likes-Details-Share

  Show description for 575b40c
  

  Antonis Lilis

  authored
  575b40c

• Refactors the BlockType to Kotlin

  

  Antonis Lilis

  committed
  4c67a69

• Refactors the NoteBlockLinkMovementMethod to Kotlin

  

  Antonis Lilis

  committed
  452d4a4

• Refactors NoteBlock to Kotlin

  

  Antonis Lilis

  committed
  d477412

• Converts NoteBlockClickableSpan to Kotlin

  

  Antonis Lilis

  committed
  0c9e71b

• Removes force unwraps

  

  Antonis Lilis

  committed
  a7f5451

Commits on Apr 25, 2024

• Renames notifications filter selection event for clarity

  

  Antonis Lilis

  committed
  a8052f1

• Replace RelativeLayout with ConstraintLayout for better performance

  

  Jarvis Lin

  committed
  a372c78

• Merge branch 'feature/notifications_refresh_p2' into issue/comment-redesign

  

  Jarvis Lin

  committed
  a05cacb

• Merge pull request #20713 from wordpress-mobile/task/rename-filter-selection-event

  Show description for 4bfd0f4
  jarvislin

  authored
  4bfd0f4

• Fixes test code build issue

  

  Antonis Lilis

  committed
  9fd9d9a

• Extract NotificationCommenDetailFragment and SiteCommentDetailFragment, and move code from onCreate/newInstance from CommenDetailFragment

  

  Jarvis Lin

  committed
  dffcc2e

• Merge pull request #20711 from wordpress-mobile/task/noteblock-to-kotlin

  Show description for 1c4b4a1
  

  Antonis Lilis

  authored
  1c4b4a1

• Hides notification title for milestones

  

  Antonis Lilis

  committed
  12d99ca

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  1243ed0

• Refactors FooterNoteBlock to Kotlin

  

  Antonis Lilis

  committed
  d322ffe

• Converts HeaderNoteBlock to Kotlin

  

  Antonis Lilis

  committed
  1fb78bd

Commits on Apr 26, 2024

• Moved setNote()

  

  Jarvis Lin

  committed
  a69e214

• Moved setComment()

  

  Jarvis Lin

  committed
  04a7d99

• Remove redundant functions

  

  Jarvis Lin

  committed
  e843cab

• Convert NoteBlockAdapter to Kotlin

  

  Jarvis Lin

  committed
  c686954

• Merge branch 'feature/notifications_refresh_p2' into issue/comment-refactor-1

  

  Jarvis Lin

  committed
  2f8fdb5

• Fix errors related to nullable variables

  

  Jarvis Lin

  committed
  f42aee6

• Tackle detekt issues

  

  Antonis Lilis

  committed
  213c573

• Convert UserNoteBlock to Kotlin

  

  Antonis Lilis

  committed
  cf412b9

• Refactor CommentUserNoteBlock to Kotlin

  

  Antonis Lilis

  committed
  d6fa715

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  19ea81b

• Merge branch 'feature/notifications_refresh_p2' into task/noteblock-to-kotlin-2

  

  Antonis Lilis

  committed
  71c80da

• Merge branch 'task/noteblock-to-kotlin-2' into task/23-milestone-basic-1

  

  Antonis Lilis

  committed
  76fcd0d

• Detect achievement notification based on raw type

  

  Antonis Lilis

  committed
  49035a2

• Adds test for the isAchievement method

  

  Antonis Lilis

  committed
  d1e527a

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  f476a2f

• Merge branch 'feature/notifications_refresh_p2' into task/noteblock-to-kotlin-2

  

  Antonis Lilis

  committed
  ab909b2

• Merge branch 'task/noteblock-to-kotlin-2' into task/23-milestone-basic-1

  

  Antonis Lilis

  committed
  b61a612

Commits on Apr 29, 2024

• Merge pull request #20718 from wordpress-mobile/task/noteblock-to-kotlin-2

  Show description for 2a1b240
  jarvislin

  authored
  2a1b240

• Merge branch 'feature/notifications_refresh_p2' into issue/comment-refactor

  Show description for 4776618
  

  Jarvis Lin

  committed
  4776618

Commits on May 3, 2024

• Fix lint issues

  

  Jarvis Lin

  committed
  2fb1428

• Refactor the layout file for better performance

  

  Jarvis Lin

  committed
  cb3cf7e

• Revert a commit which will be included in another PR

  

  Jarvis Lin

  committed
  0bcb056

• Add a header in the screen of Comment Details

  

  Jarvis Lin

  committed
  c901f5e

• Fix a lint issue of RelativeLayout

  

  Jarvis Lin

  committed
  7768eb8

• Replace titles with empty string

  

  Jarvis Lin

  committed
  e3ec832

• Replace the black background with gray color

  

  Jarvis Lin

  committed
  a275a71

Commits on May 7, 2024

• Merge pull request #20762 from wordpress-mobile/issue/update-background-color

  Show description for 43a6593
  

  Antonis Lilis

  authored
  43a6593

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  8548a93

• Merge branch 'feature/notifications_refresh_p2' into task/23-milestone-basic-1

  

  Antonis Lilis

  committed
  b1e27f2

Commits on May 8, 2024

• Adds unit test for achivement type

  

  Antonis Lilis

  committed
  9b612b3

• Update the arrow icon and add an avatar

  

  Jarvis Lin

  committed
  0068323

• Replace the if condition with note.isCommentType()

  

  Jarvis Lin

  committed
  bd7e4f7

• Remove the redundant comment

  

  Jarvis Lin

  committed
  b02ad5f

• Remove the redundant const

  

  Jarvis Lin

  committed
  6999f67

• Merge pull request #20715 from wordpress-mobile/task/23-milestone-basic-1

  Show description for 7e6d151
  jarvislin

  authored
  7e6d151

• Merge pull request #20759 from wordpress-mobile/issue/comment-refactor-part-1

  Show description for fc8d810
  jarvislin

  authored
  fc8d810

• Merge branch 'feature/notifications_refresh_p2' into issue/comment-details-header

  Show description for 3b6fa36
  

  Jarvis Lin

  committed
  3b6fa36

• Move function to subclasses

  

  Jarvis Lin

  committed
  112db04

Commits on May 9, 2024

• Update layouts and remove some redundant logic

  

  Jarvis Lin

  committed
  8d88bfa

Commits on May 10, 2024

• Merge branch 'trunk' into feature/notifications_refresh_p2

  Show description for e05b568
  

  Antonis Lilis

  committed
  e05b568

• Renames follows to subscribers

  

  Antonis Lilis

  committed
  60c6e57

• Merge pull request #20794 from wordpress-mobile/task/notifs-follow-to-subscribe

  Show description for 4609aaa
  jarvislin

  authored
  4609aaa

• Merge pull request #20761 from wordpress-mobile/issue/comment-details-header

  Show description for 39d6033
  jarvislin

  authored
  39d6033

• Ignore the replied footer on UI

  

  Jarvis Lin

  committed
  5618cdf

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  d8edd7a

• Remove the action binding and related functions

  

  Jarvis Lin

  committed
  79e0915

• Fix lint issues

  

  Jarvis Lin

  committed
  65a6bb0

• Merge branch 'feature/notifications_refresh_p2' into issue/comment-details-content

  Show description for 880e609
  

  Jarvis Lin

  committed
  880e609

• Fix some UI issues related to the header

  

  Jarvis Lin

  committed
  348774e

• Add a comment

  

  Jarvis Lin

  committed
  5dfac69

Commits on May 13, 2024

• Add a menu button in Comment Details

  

  Jarvis Lin

  committed
  8c5d27b

Commits on May 14, 2024

• Separate milestone notification detail implementation

  

  Antonis Lilis

  committed
  fef010a

• Add the popup window

  

  Jarvis Lin

  committed
  b0be301

• Handle the Edit comment action

  

  Jarvis Lin

  committed
  c02aace

Commits on May 15, 2024

• Refactor the user profile bottom sheet

  

  Jarvis Lin

  committed
  8ffe0f3

• Refactor the codebase related to Comment Actions

  

  Jarvis Lin

  committed
  2dd8b4a

• Reset binding to null when the view is destroyed

  

  Jarvis Lin

  committed
  912a8d4

• Handle the comment action of User Info for the comment notifications

  

  Jarvis Lin

  committed
  c660322

Commits on May 16, 2024

• Display user info in the screen of My Site -> Comment List -> Comment

  

  Jarvis Lin

  committed
  6070f47

• Fix lint issues

  

  Jarvis Lin

  committed
  5456a99

• Rename a variable

  

  Jarvis Lin

  committed
  2ab5cf0

• Update a comment

  

  Jarvis Lin

  committed
  d1bf95b

• Update layout settings

  

  Jarvis Lin

  committed
  a752f8a

• Fix some RTL issues

  

  Jarvis Lin

  committed
  381bb1d

• Fix a test

  

  Jarvis Lin

  committed
  dc5cbe4

Commits on May 20, 2024

• Use orEmpty() to handle the empty strings

  

  Jarvis Lin

  committed
  2b82a68

• Use get() for handling a non-null variable

  

  Jarvis Lin

  committed
  360d311

Commits on May 23, 2024

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  8fe1855

Commits on May 24, 2024

• Replace mNote with note

  

  Jarvis Lin

  committed
  d04ef21

• Use get() to handle a non-null variable

  

  Jarvis Lin

  committed
  1b18034

• Merge pull request #20798 from wordpress-mobile/issue/comment-details-content

  Show description for afec253
  jarvislin

  authored
  afec253

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  d1cced5

Commits on May 27, 2024

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  ada3159

• Merge branch 'feature/notifications_refresh_p2' into task/20715-extract-milestone-fragment

  Show description for f105265
  

  Antonis Lilis

  committed
  f105265

Commits on May 28, 2024

• Remove unused code and add the layout of pending state of comment

  

  Jarvis Lin

  committed
  b1702b0

• Add a bottom sheet for moderation

  

  Jarvis Lin

  committed
  11ba7e8

• Extract strings

  

  Jarvis Lin

  committed
  e5d2614

• Handle RTL

  

  Jarvis Lin

  committed
  e5c2dd5

Commits on May 29, 2024

• Define the peekHeight to avoid our bottom sheet expanding partially

  

  Jarvis Lin

  committed
  1cdf268

• Merge pull request #20894 from wordpress-mobile/issue/comment-details-pending-moderation

  Show description for fd16904
  jarvislin

  authored
  fd16904

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  e3c7f16

• Merge branch 'feature/notifications_refresh_p2' into task/20715-extract-milestone-fragment

  

  Antonis Lilis

  committed
  f17d3a5

• Update the moderation bottom sheet and make some extension functions of comment

  

  Jarvis Lin

  committed
  bc0d712

Commits on May 30, 2024

• Implement like/unlike a comment

  

  Jarvis Lin

  committed
  e9fb386

• Handle the style and the icon for a text view

  

  Jarvis Lin

  committed
  9d06cc1

• Implement Approve function

  

  Jarvis Lin

  committed
  9ebfde6

• Fix lint issues

  

  Jarvis Lin

  committed
  b71b440

• Extracts NoteBlockTextClickListener

  

  Antonis Lilis

  committed
  14346e8

• Add tests

  

  Jarvis Lin

  committed
  e60a6ab

• Move milestone related functionality to the MilestoneDetailFragment

  

  Antonis Lilis

  committed
  65d86dd

• Creates a separate NoteBlock for milestones

  

  Antonis Lilis

  committed
  cdb2796

• Removes confetti animation

  

  Antonis Lilis

  committed
  cd2e2ed

• Fixes note text

  

  Antonis Lilis

  committed
  e71e080

• Removes confetti animation resource

  

  Antonis Lilis

  committed
  50dc92f

Commits on May 31, 2024

• Adds NonNull annotation

  

  Antonis Lilis

  authored
  0b495ec

• Merge pull request #20916 from wordpress-mobile/issue/comment-details-approve-moderation

  Show description for 4f00ccc
  jarvislin

  authored
  4f00ccc

• Pass note_id as bundle argument

  

  Antonis Lilis

  committed
  a86f365

• Replace the deprecated onActivityCreated with onViewCreated

  

  Antonis Lilis

  committed
  4ba97f4

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  e52ef49

• Merge branch 'feature/notifications_refresh_p2' into task/20715-extract-milestone-fragment

  

  Antonis Lilis

  committed
  ffa464e

• Moves note retrieval in the background

  

  Antonis Lilis

  committed
  b187f85

• Merge pull request #20809 from wordpress-mobile/task/20715-extract-milestone-fragment

  Show description for 9f6e573
  jarvislin

  authored
  9f6e573

Commits on Jun 6, 2024

• Handle the share action

  

  Jarvis Lin

  committed
  5f9c0a5

• Handle the click of changing status in the comment menu

  

  Jarvis Lin

  committed
  9f6b69c

• Fix lint issues

  

  Jarvis Lin

  committed
  78a2b09

Commits on Jun 7, 2024

• Merge pull request #20944 from wordpress-mobile/issue/Comment-Details-Menu-redesign

  Show description for 5493500
  

  Antonis Lilis

  authored
  5493500

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  3f7e49f

• Add the implementation of trash action

  

  Jarvis Lin

  committed
  852282b

• Fix the flow of dispatching moderation actions

  

  Jarvis Lin

  committed
  d537c35

• Handle spam action

  

  Jarvis Lin

  committed
  1735251

Commits on Jun 10, 2024

• Make some refactors

  

  Jarvis Lin

  committed
  d0fa51a

Commits on Jun 11, 2024

• Merge pull request #20952 from wordpress-mobile/issue/Comment-Details-Trash-moderation-redesign

  Show description for 34a279c
  

  Antonis Lilis

  authored
  34a279c

• Merge branch 'trunk' into feature/notifications_refresh_p2

  

  Antonis Lilis

  committed
  987d1f7