-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Notifications Refresh] 🤖 Milestone Details: hides the title for achievements #20715
[Notifications Refresh] 🤖 Milestone Details: hides the title for achievements #20715
Conversation
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/notifications_refresh_p2 #20715 +/- ##
====================================================================
+ Coverage 40.68% 40.70% +0.01%
====================================================================
Files 1490 1490
Lines 68551 68573 +22
Branches 11359 11359
====================================================================
+ Hits 27891 27913 +22
Misses 38142 38142
Partials 2518 2518 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work as usual. I've tested with N Likes
and First post
milestones, they work as expected without the title.
This PR covers just item 1 of https://github.com/Automattic/wordpress-mobile/issues/23 and introduces a new mechanism for identifying achievement/milestone notifications (ref p1714062709630809/1714052620.609979-slack-C06BWNSR02K).
The rest of the items will be covered in follow up PRs after refactoring part of the code.
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):