Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications Refresh] 🤖 Milestone Details: hides the title for achievements #20715

Merged

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Apr 25, 2024

This PR covers just item 1 of https://github.com/Automattic/wordpress-mobile/issues/23 and introduces a new mechanism for identifying achievement/milestone notifications (ref p1714062709630809/1714052620.609979-slack-C06BWNSR02K).
The rest of the items will be covered in follow up PRs after refactoring part of the code.


To Test:

  1. Open a milstone notifications
  2. Verify that no title is shown

Regression Notes

  1. Potential unintended areas of impact

    • Milestone notifications
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • Added unit tests

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@antonis antonis added this to the Future milestone Apr 25, 2024
@antonis antonis changed the base branch from trunk to feature/notifications_refresh_p2 April 25, 2024 14:51
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 25, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20715-9b612b3
Commit9b612b3
Direct Downloadjetpack-prototype-build-pr20715-9b612b3.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 25, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20715-9b612b3
Commit9b612b3
Direct Downloadwordpress-prototype-build-pr20715-9b612b3.apk
Note: Google Login is not supported on these builds.

@antonis antonis changed the base branch from feature/notifications_refresh_p2 to task/noteblock-to-kotlin-2 April 26, 2024 11:28
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.70%. Comparing base (8548a93) to head (9b612b3).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           feature/notifications_refresh_p2   #20715      +/-   ##
====================================================================
+ Coverage                             40.68%   40.70%   +0.01%     
====================================================================
  Files                                  1490     1490              
  Lines                                 68551    68573      +22     
  Branches                              11359    11359              
====================================================================
+ Hits                                  27891    27913      +22     
  Misses                                38142    38142              
  Partials                               2518     2518              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from task/noteblock-to-kotlin-2 to feature/notifications_refresh_p2 April 29, 2024 03:46
@antonis antonis changed the title [Notifications Refresh] 🤖 Milestone Details: Basic content [Notifications Refresh] 🤖 Milestone Details: hides the title for achievements May 8, 2024
@antonis antonis marked this pull request as ready for review May 8, 2024 06:12
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antonis antonis requested a review from jarvislin May 8, 2024 07:09
Copy link
Contributor

@jarvislin jarvislin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as usual. I've tested with N Likes and First post milestones, they work as expected without the title.

@jarvislin jarvislin merged commit 7e6d151 into feature/notifications_refresh_p2 May 8, 2024
23 checks passed
@jarvislin jarvislin deleted the task/23-milestone-basic-1 branch May 8, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants