[Notifications Refresh] 🤖 Milestone Details: Badge and Title

[antonis]

Description

This PR:

• Refactors the code separating the milestone implementation
• Removes deprecated code
• Partially implements https://github.com/Automattic/wordpress-mobile/issues/23:
  3️⃣ Set the achievement icon
  4️⃣ Set the achievement text
  The rest of the items will be covered in follow up PRs.

---

To Test:

1. Open the notifications tab
2. Open a milestone notification
3. Verify that the badge and text is displayed as expected
4. Browse other notification types
5. Verify that the functionality is unchanged

---

Regression Notes

1. Potential unintended areas of impact

   • Milestone notifications

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual testing

3. What automated tests I added (or what prevented me from doing so)

   • Will iterate on a follow up PR

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist (strike-out the not-applying and unnecessary ones):

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	3 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	Class NoteBlockTextClickListener is missing tests, but unit-tests-exemption label was set to ignore this.
⚠️	Class MilestoneNoteBlock is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20809-b187f85
	Commit	b187f85
	Direct Download	jetpack-prototype-build-pr20809-b187f85.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20809-b187f85
	Commit	b187f85
	Direct Download	wordpress-prototype-build-pr20809-b187f85.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 40.98%. Comparing base (e52ef49) to head (b187f85).

Files	Patch %	Lines
...oid/ui/notifications/NoteBlockTextClickListener.kt	0.00%	52 Missing ⚠️
...roid/ui/notifications/blocks/MilestoneNoteBlock.kt	0.00%	9 Missing ⚠️
...press/android/ui/notifications/blocks/NoteBlock.kt	0.00%	2 Missing ⚠️

Additional details and impacted files

@@                         Coverage Diff                          @@
##           feature/notifications_refresh_p2   #20809      +/-   ##
====================================================================
- Coverage                             41.01%   40.98%   -0.04%     
====================================================================
  Files                                  1521     1523       +2     
  Lines                                 69563    69626      +63     
  Branches                              11492    11513      +21     
====================================================================
  Hits                                  28534    28534              
- Misses                                38441    38504      +63     
  Partials                               2588     2588              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jarvislin]

Thank you for implementing the milestone feature, I just reviewed this PR and left comments, there are some issues might be needed to adjust.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jarvislin]

Thank you so much for making these adjustments, I just tested and I didn't find any issues after the changes. Great job!