Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reader] Your Tags Feed #20812

Merged
merged 289 commits into from
May 25, 2024
Merged

[Reader] Your Tags Feed #20812

merged 289 commits into from
May 25, 2024

Conversation

RenanLukas
Copy link
Contributor

Feature branch of Tags IA project (ref: pcdRpT-6hp-p2)

RenanLukas and others added 30 commits April 15, 2024 12:36
@RenanLukas
Remove blog avatar, fix excerpt max lines
07194ea
@RenanLukas
Merge branch 'issue/20587-implement-horizontal-posts-list-ui-componen…
53b507c 
…t' into issue/20268-implement-horizontal-post-list-ui-shimmer
@RenanLukas
Remove blog avatar from loading
b970e1d
@RenanLukas
Fix spacing between number of likes and like button in HorizontalPost…
4616094 
…ListItem
@RenanLukas
Merge branch 'issue/20587-implement-horizontal-posts-list-ui-componen…
96225d2 
…t' into issue/20268-implement-horizontal-post-list-ui-shimmer
@RenanLukas
Fix detekt, remove extra padding
907d5df
@RenanLukas
Create HorizontalPostList file
eeffadd
@RenanLukas
Fix like icon start padding
f1b2baf
@RenanLukas
Merge branch 'issue/20587-implement-horizontal-posts-list-ui-componen…
bb34a6f 
…t' into issue/20268-implement-horizontal-post-list-ui-shimmer
@RenanLukas
Merge branch 'issue/20268-implement-horizontal-post-list-ui-shimmer' …
1a6a8bf 
…into issue/20623-implement-horizontal-posts-list-ui-component
Create ReaderPostRepository
d0ea2ae
@RenanLukas
Refactor reader tags feed components package
dbb0f83
Replace StringUtils by kotlin extensions
8145b0a
@RenanLukas
Merge pull request #20614 from wordpress-mobile/issue/20587-implement…
76374d8 
…-horizontal-posts-list-ui-component

[Reader] Implement "Tags" feed horizontal posts list item component
@RenanLukas
Move shimmer color to generic component
212400e
@RenanLukas
Merge branch 'issue/20268-implement-horizontal-post-list-ui-shimmer' …
7c73213 
…into issue/20623-implement-horizontal-posts-list-ui-component
@RenanLukas
WIP ReaderTagsFeed UI
538fc5b
@RenanLukas
WIP Reader tags feed UI states
6475dd1
@RenanLukas
Implement ReaderTagsFeed preview
4f9c2f5
@RenanLukas
Change shimmer implementation
4a8a19a
@RenanLukas
Fix detekt
429fcbf
@RenanLukas
Merge branch 'issue/20268-implement-horizontal-post-list-ui-shimmer' …
4fb8871 
…into issue/20623-implement-horizontal-posts-list-ui-component
Create function to fetch newer posts for tag
e596f1c
Create ViewModel methods to fetch posts for Tags Feed
23a0771
Create temporary UI for testing tag fetching
d95ab6f
@RenanLukas
Add onTagClicked parameter to TagsFeedItem
527a689
@RenanLukas
Fix horizontal list item spacing
5c592c6
@RenanLukas
Implement ReaderTagsFeed loading state
831dbdf
@RenanLukas
Implement loading posts and tags loaded state for ReaderTagsFeed
aa2b46f
@RenanLukas
Remove shimmer effect
3ae8b58
Thomas Horta and others added 17 commits May 23, 2024 21:16
Update Announcement unit tests
c232b01
Remove the announcement compose view from reader_fragment_layout.xml
2375887
Improve Item View Type logic
f7c9246
Fix detekt issue
9172623
Hide Announcement in Subscriptions feed when filtered
6085d9c
Add Reader Announcement on Tags Feed
16bc145
Update mapper tests
6738e9b
Update unit tests for ReaderTagsFeedViewModel
b37f1bf
Remove shouldShow from ReaderAnnouncementCard
7d83aa2
Turn on Reader Tags Feed FF by default
5d8db54
Turn on Reader Announcement FF by default
eb93505
Rename Announcement repo to ReaderAnnouncementHelper
911be72
Merge branch 'issue/20621-announcement-card-in-feeds' of github.com:w…
a862f9b 
…ordpress-mobile/WordPress-Android into issue/20621-announcement-card-in-tags-feed
Merge pull request #20872 from wordpress-mobile/issue/20621-announcem…
fef5649 
…ent-card-in-feeds

[Reader] Move announcement card inside the feeds
@RenanLukas
Merge pull request #20877 from wordpress-mobile/issue/20621-announcem…
adf8393 
…ent-card-in-tags-feed

[Reader] Also add announcement card into the new Tags Feed
@RenanLukas
Merge pull request #20879 from wordpress-mobile/issue/reader-tags-ann…
13c2b12 
…ouncement-enable-ff

[Tags Feed] Enable FFs by default for Tags Feed and Announcement
@RenanLukas
Merge branch 'trunk' into feature/tags-ia
10d743d
@RenanLukas RenanLukas marked this pull request as ready for review May 24, 2024 23:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Passed Quality Gate passed

Issues
34 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.8% Duplication on New Code

See analysis details on SonarCloud

@RenanLukas RenanLukas removed the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label May 25, 2024
thomashorta
thomashorta approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@thomashorta thomashorta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all commits here were reviewed in other PRs I just took a quick overall look and tested a few scenarios. LGTM!

One minor nitpick: should the PR name be more descriptive, like "[Reader] Your Tags Feed"?

@thomashorta thomashorta added this to the 25.0 milestone May 25, 2024
@RenanLukas RenanLukas changed the title [Feature] Tags IA [Reader] Your Tags Feed May 25, 2024
@RenanLukas RenanLukas merged commit b4d6861 into trunk May 25, 2024
23 checks passed
@RenanLukas RenanLukas deleted the feature/tags-ia branch May 25, 2024 01:13
@develric develric mentioned this pull request May 26, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashorta thomashorta thomashorta approved these changes

@daniloercoli daniloercoli Awaiting requested review from daniloercoli

@develric develric Awaiting requested review from develric

Assignees
No one assigned
Labels
Reader
Projects
None yet
Milestone
25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RenanLukas @dangermattic @wpmobilebot @thomashorta @develric