-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags Feed] Implement no connection state #20842
[Tags Feed] Implement no connection state #20842
Conversation
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/tags-ia #20842 +/- ##
===================================================
+ Coverage 40.82% 40.84% +0.01%
===================================================
Files 1493 1493
Lines 68750 68766 +16
Branches 11346 11350 +4
===================================================
+ Hits 28070 28087 +17
+ Misses 38132 38131 -1
Partials 2548 2548 ☔ View full report in Codecov by Sentry. |
Hey Thomas! 👋
|
hey @daniloercoli, thanks for the Review! This PR only touches the So currently this only targets the Tags Feed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed #20842 (comment), this PR only addresses the Tags Feed, so LGTM!
Fixes #20815
NoConnection
state for showing an error message when the Feed is opened without an internet connectionLoading
when there is an internet connectionNoConnection
andPostList.Error
statesTo Test:
reader_tags_feed
FeatureConfig is ON (Debug Settings
->Remote Features
Your Tags
feedRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):