Updates: RELEASE-NOTES for in-app updates #20856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20856-77ed111 | |
| Commit | 77ed111 | |
| Direct Download | jetpack-prototype-build-pr20856-77ed111.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20856-77ed111 | |
| Commit | 77ed111 | |
| Direct Download | wordpress-prototype-build-pr20856-77ed111.apk |
AjeshRPai
reviewed
May 21, 2024
RELEASE-NOTES.txt
Outdated
| @@ -8,6 +8,7 @@ | |||
| * [*] Fixed a rare crash on the featured image confirmation dialog [https://github.com/wordpress-mobile/WordPress-Android/pull/20836] | |||
| * [*] Fixed an ANR issue on the Post List screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20833] | |||
| * [*] [internal] Block Editor: Upgrade target sdk version to Android API 34 [https://github.com/wordpress-mobile/WordPress-Android/pull/20841] | |||
| * [*] In-app updates feature [https://github.com/wordpress-mobile/WordPress-Android/pull/20822] | |||
There was a problem hiding this comment.
We should the [internal] tag at the starting of the line
* [*] [internal] In-app updates feature [https://github.com/wordpress-mobile/WordPress-Android/pull/20822]
There was a problem hiding this comment.
I have done it in a commit. Hope its ok with you. Approving the PR. Leaving it for you to merge
AjeshRPai
approved these changes
May 21, 2024
RELEASE-NOTES.txt
Outdated
| @@ -8,6 +8,7 @@ | |||
| * [*] Fixed a rare crash on the featured image confirmation dialog [https://github.com/wordpress-mobile/WordPress-Android/pull/20836] | |||
| * [*] Fixed an ANR issue on the Post List screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20833] | |||
| * [*] [internal] Block Editor: Upgrade target sdk version to Android API 34 [https://github.com/wordpress-mobile/WordPress-Android/pull/20841] | |||
| * [*] In-app updates feature [https://github.com/wordpress-mobile/WordPress-Android/pull/20822] | |||
There was a problem hiding this comment.
I have done it in a commit. Hope its ok with you. Approving the PR. Leaving it for you to merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a line in RELEASE-NOTES.txt for the in-app updates feature.
Related PR here.
To Test:
Just check the code changes.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):