-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags Feed] Update feed tags as Diff, keeping existing tag content #20860
[Tags Feed] Update feed tags as Diff, keeping existing tag content #20860
Conversation
Keep existing tags content untouched and only add new tags in initial state for new tags, so the list updates in place. Also add placement animation to the list items for a better UX.
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/tags-ia #20860 +/- ##
===================================================
+ Coverage 40.88% 40.91% +0.03%
===================================================
Files 1493 1493
Lines 68770 68794 +24
Branches 11350 11352 +2
===================================================
+ Hits 28117 28149 +32
+ Misses 38098 38091 -7
+ Partials 2555 2554 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM.
Fixes #20811
When a new
onTagsChanged
is called and the current UI State isLoaded
, let's just update the tags list and keep any content we already fetched before, by:To Test:
reader_tags_feed
Feature Config is ONYour Tags
feedMore from
You can also test adding a new tag by:
Your Tags
feedMore from
Your Tags
feedRegression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):