-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Implement announcement card improvements #20861
[Reader] Implement announcement card improvements #20861
Conversation
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/tags-ia #20861 +/- ##
===================================================
+ Coverage 40.83% 40.85% +0.01%
===================================================
Files 1494 1494
Lines 68771 68780 +9
Branches 11349 11352 +3
===================================================
+ Hits 28086 28097 +11
+ Misses 38139 38126 -13
- Partials 2546 2557 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RenanLukas 🙇 ! As we discussed we will see if we can look at a way that scales to the other screens as well but this is looking better already 👍 . Approving and merging 🎉
Fixes #20621
Shows the Reader announcement card just on "Discover" feed and implements the suggestions made by @develric.
Screen.Recording.2024-05-22.at.12.31.20.AM.mov
To Test:
reader_announcement_card
feature flag is disabled.reader_announcement_card
feature flag.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
ReaderViewModelTest
.PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):