Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader] Show filters in A8C and P2 feeds #20867

Merged
merged 1 commit into from
May 23, 2024

Conversation

thomashorta
Copy link
Contributor

Some changes related to Tags Feed caused the Blog filter to disappear in other Filterable feeds, such as the Automattic and P2 feeds. This PR fixes that issue by making sure the Blog filter ONLY doesn't show for Tags Feed.


To Test:

  1. Open Jetpack
  2. Login with an A8C account
  3. Turn on reader_tags_feed FF
  4. Go to Reader
  5. Go to Automattic feed
  6. Verify the N Blogs filter shows up and works

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20867-6c51762
Commit6c51762
Direct Downloadjetpack-prototype-build-pr20867-6c51762.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20867-6c51762
Commit6c51762
Direct Downloadwordpress-prototype-build-pr20867-6c51762.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.94%. Comparing base (5600b47) to head (6c51762).

Files Patch % Lines
...ss/android/ui/reader/viewmodels/ReaderViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feature/tags-ia   #20867   +/-   ##
================================================
  Coverage            40.94%   40.94%           
================================================
  Files                 1494     1494           
  Lines                68838    68838           
  Branches             11358    11358           
================================================
  Hits                 28189    28189           
  Misses               38086    38086           
  Partials              2563     2563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Tested and it looks good to merge.
Not for now, but would also be good to have the site selector on Lists.

@thomashorta thomashorta merged commit 9213b67 into feature/tags-ia May 23, 2024
21 of 23 checks passed
@thomashorta thomashorta deleted the fix/tags-ia-filter-in-filterable-feeds branch May 23, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants